Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gotmpl): cleanup tree-sitter #507

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

qvalentin
Copy link
Contributor

Hi, thanks for the nice plugin.

I help upstreaming https://github.com/ngalaiko/tree-sitter-go-template to https://github.com/nvim-treesitter/nvim-treesitter and think this should be updated in this plugin.

Changes:

  • Update docs to install gotmpl tree-sitter directly from nvim-treesitter
  • remove queries/gotmpl/highlights.scm since this is already in nvim-treesitter
  • update injections, (text) @yaml has no effect I guess?
  • To be discussed: the injections file currently sets up html and javascript injections, which is kind of weird, since it means two tree-sitter parsers are used for the same text at the same time
    • this also means if the user want to template yaml the html and js parser will be active for those files

Copy link
Owner

@ray-x ray-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ray-x ray-x merged commit 2aa81c6 into ray-x:master Sep 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants