Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[projects] Project examples and documentation #5407

Merged
merged 23 commits into from
Aug 21, 2019
Merged

[projects] Project examples and documentation #5407

merged 23 commits into from
Aug 21, 2019

Conversation

pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Aug 8, 2019 •
edited
Loading

What do these changes do?

This adds some example projects and documentation about the Ray projects functionality.

Related issue number

Linter

  • I've run scripts/format.sh to lint the changes in this PR.

@pcmoritz pcmoritz changed the title [WIP] [projects] project examples [WIP] [projects] project examples and documentation Aug 8, 2019
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16144/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16145/
Test FAILed.

edoakes
edoakes reviewed Aug 8, 2019
View reviewed changes
Copy link
Contributor

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

doc/source/projects.rst Outdated Show resolved Hide resolved
doc/source/projects.rst Outdated
# describing the cluster configuration.
$ ray project create <project-name>

# Create a new session from the given project with an optional name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you don't give it a name? autogen'd?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment it will be autogenerated as the project name, once we support multiple concurrent sessions we should have a smarter way to autogenerate it.

doc/source/projects.rst Outdated Show resolved Hide resolved
doc/source/projects.rst Outdated Show resolved Hide resolved
doc/source/projects.rst Outdated Show resolved Hide resolved
doc/source/projects.rst Outdated Show resolved Hide resolved
doc/source/projects.rst Outdated Show resolved Hide resolved
python/ray/projects/examples/mozilla-deepspeech/.rayproject/cluster.yaml Outdated Show resolved Hide resolved
python/ray/projects/examples/open-tacotron/.rayproject/cluster.yaml Outdated Show resolved Hide resolved
python/ray/projects/examples/open-tacotron/.rayproject/cluster.yaml Outdated Show resolved Hide resolved
pcmoritz and others added 9 commits August 8, 2019 16:10
@pcmoritz @edoakes
Update doc/source/projects.rst
941a934 
Co-Authored-By: Edward Oakes <[email protected]>
@pcmoritz @edoakes
Update doc/source/projects.rst
4602c9f 
Co-Authored-By: Edward Oakes <[email protected]>
@pcmoritz @edoakes
Update doc/source/projects.rst
06cee07 
Co-Authored-By: Edward Oakes <[email protected]>
@pcmoritz @edoakes
Update doc/source/projects.rst
7cf79ab 
Co-Authored-By: Edward Oakes <[email protected]>
@pcmoritz @edoakes
Update doc/source/projects.rst
a462603 
Co-Authored-By: Edward Oakes <[email protected]>
@pcmoritz @edoakes
Update python/ray/projects/examples/mozilla-deepspeech/.rayproject/cl…
d2fab51 
…uster.yaml

Co-Authored-By: Edward Oakes <[email protected]>
@pcmoritz @edoakes
Update python/ray/projects/examples/open-tacotron/.rayproject/cluster…
7e03ea4 
….yaml

Co-Authored-By: Edward Oakes <[email protected]>
@pcmoritz @edoakes
Update python/ray/projects/examples/open-tacotron/.rayproject/cluster…
825afc7 
….yaml

Co-Authored-By: Edward Oakes <[email protected]>
@pcmoritz
update
d9fc5fc
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16148/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16162/
Test FAILed.

ericl
ericl reviewed Aug 9, 2019
View reviewed changes
doc/source/projects.rst
.. code-block:: bash

# Creates a project in the current directory. It will create a
# project.yaml defining the code and environment and a cluster.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to infer the env based on current conda installed packages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet but should be, I created an issue here: #5487

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16163/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16164/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16411/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16410/
Test PASSed.

@pcmoritz pcmoritz changed the title [WIP] [projects] project examples and documentation [projects] project examples and documentation Aug 20, 2019
@pcmoritz pcmoritz changed the title [projects] project examples and documentation [projects] Project examples and documentation Aug 20, 2019
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16414/
Test PASSed.

stephanie-wang
stephanie-wang reviewed Aug 20, 2019
View reviewed changes
doc/source/projects.rst Outdated Show resolved Hide resolved
doc/source/projects.rst Outdated Show resolved Hide resolved
doc/source/projects.rst Outdated Show resolved Hide resolved
doc/source/projects.rst Show resolved Hide resolved
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16421/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16423/
Test PASSed.

@pcmoritz pcmoritz merged commit c852213 into ray-project:master Aug 21, 2019
@pcmoritz pcmoritz deleted the project-examples branch August 21, 2019 03:49
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16426/
Test PASSed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl left review comments

@stephanie-wang stephanie-wang stephanie-wang left review comments

@edoakes edoakes edoakes left review comments

@simon-mo simon-mo simon-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pcmoritz @AmplabJenkins @ericl @stephanie-wang @edoakes @simon-mo