Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS file #5259

Merged
merged 5 commits into from
Jul 26, 2019
Merged

Add CODEOWNERS file #5259

merged 5 commits into from
Jul 26, 2019

Conversation

raulchen
Copy link
Contributor

What do these changes do?

Add the CODEWONERS file, which defines the owners of each module. When a PR touches a file of a module, the corresponding owners will be automatically added as reviewers.

Related issue number

Linter

  • I've run scripts/format.sh to lint the changes in this PR.

@raulchen
Copy link
Contributor Author

The owners are grouped by teams, e.g. @ray-project/ray-core-cpp. I haven't created those teams yet. Please let me know if you have better ideas about how to categorize the code.

@richardliaw richardliaw changed the title Add CODEWONERS file Add CODEOWNERS file Jul 24, 2019
/bazel/ @ray-project/ray-core

# CI.
/ci/ @ray-project/ray-core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would exclude ci/ since a lot of RLlib / tune / misc tests go through this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this to only include the CI scripts.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15609/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15611/
Test PASSed.

.github/CODEOWNERS Outdated Show resolved Hide resolved
@robertnishihara
Copy link
Collaborator

It might make sense to make it even more fine-grained, e.g., also include the autoscaler and the build system as two separate groups. We can also try what you have and see if it's helping and iterate.

Co-Authored-By: Robert Nishihara <[email protected]>
@raulchen
Copy link
Contributor Author

yeah, we can try this first and make it more fine-grained later.
Comments are addressed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15634/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1780/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1783/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1785/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1807/
Test FAILed.

@raulchen
Copy link
Contributor Author

@robertnishihara @ericl any other comments?

Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's try it out

@raulchen raulchen merged commit 6f737e6 into ray-project:master Jul 26, 2019
@raulchen raulchen deleted the code_owners branch July 26, 2019 04:40
edoakes pushed a commit to edoakes/ray that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants