-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CODEOWNERS file #5259
Add CODEOWNERS file #5259
Conversation
The owners are grouped by teams, e.g. |
.github/CODEOWNERS
Outdated
/bazel/ @ray-project/ray-core | ||
|
||
# CI. | ||
/ci/ @ray-project/ray-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would exclude ci/ since a lot of RLlib / tune / misc tests go through this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed this to only include the CI scripts.
Test FAILed. |
Test PASSed. |
It might make sense to make it even more fine-grained, e.g., also include the autoscaler and the build system as two separate groups. We can also try what you have and see if it's helping and iterate. |
Co-Authored-By: Robert Nishihara <[email protected]>
yeah, we can try this first and make it more fine-grained later. |
Test FAILed. |
Test FAILed. |
Test FAILed. |
Test FAILed. |
Test FAILed. |
@robertnishihara @ericl any other comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's try it out
What do these changes do?
Add the
CODEWONERS
file, which defines the owners of each module. When a PR touches a file of a module, the corresponding owners will be automatically added as reviewers.Related issue number
Linter
scripts/format.sh
to lint the changes in this PR.