-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependencies from TaskExecutionSpecification #5166
Conversation
Note that this touches many of the same files as #5147 |
Test FAILed. |
Test PASSed. |
7a0803d
to
559f42f
Compare
Updated to rebase off of the changes merged in #5147 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few tiny things, but looks great!
Test FAILed. |
Test FAILed. |
Test PASSed. |
Test PASSed. |
Test FAILed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
Please try to avoid force-pushing in the future, as it makes it hard to see what the new changes are.
Test FAILed. |
Test PASSed. |
Test FAILed. |
Test PASSed. |
Test PASSed. |
This is almost ready, there is another Travis error:
|
Test FAILed. |
Test FAILed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test FAILed. |
What do these changes do?
Removes the
dependencies
field fromTaskExecutionSpecification
in favor of a newPreviousActorTaskDummyObjectId
field inTaskSpecification
.This was an artifact left over from a previous design, and the dependencies were never actually updated during runtime. Rather, it was only used to specify dependencies for actor tasks on the previously run actor task. Now, there is a dedicated field for this use case that is only specified as part of actor task submissions.
The change has a nice byproduct of simplifying the task submission interfaces in the core worker.
Related issue number
Linter
scripts/format.sh
to lint the changes in this PR.