Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Add experimental option to suppress algo config validate(); some code cleanups. #49714

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jan 8, 2025

  • Add experimental option to suppress config validation. This will allow us to make users pay attention to raised config validation errors, but at the same time give them an opt-out in case they want to use a (bad) setting no matter what. Example: Running APPO with GPU and 1 remote learner is bad. Or running APPO with CPU and 1 local learner is very slow (but might be useful for debugging).
  • Some other code cleanups.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <[email protected]>
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A small question to "auto" rollout_fragment_length.

and not self.in_evaluation
and self.total_train_batch_size > 0
):
if self.rollout_fragment_length != "auto" and not self.in_evaluation:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we only support "auto" now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just the check for train_batch_size < 0 - now that we don't have the DDPPO algo anymore - seemed superfluous. So I took out that one check.

@sven1977 sven1977 enabled auto-merge (squash) January 8, 2025 16:35
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jan 8, 2025
@sven1977 sven1977 merged commit 2ac04cc into ray-project:master Jan 9, 2025
5 of 6 checks passed
@sven1977 sven1977 deleted the add_validate_block_option_to_algo_config branch January 9, 2025 09:51
dayshah pushed a commit to dayshah/ray that referenced this pull request Jan 10, 2025
HYLcool pushed a commit to HYLcool/ray that referenced this pull request Jan 13, 2025
srinathk10 pushed a commit that referenced this pull request Feb 2, 2025
anyadontfly pushed a commit to anyadontfly/ray that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-newstack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants