-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Add experimental option to suppress algo config validate()
; some code cleanups.
#49714
[RLlib] Add experimental option to suppress algo config validate()
; some code cleanups.
#49714
Conversation
Signed-off-by: sven1977 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A small question to "auto" rollout_fragment_length
.
and not self.in_evaluation | ||
and self.total_train_batch_size > 0 | ||
): | ||
if self.rollout_fragment_length != "auto" and not self.in_evaluation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we only support "auto" now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, just the check for train_batch_size
< 0 - now that we don't have the DDPPO algo anymore - seemed superfluous. So I took out that one check.
… some code cleanups. (ray-project#49714) Signed-off-by: dayshah <[email protected]>
… some code cleanups. (ray-project#49714) Signed-off-by: lielin.hyl <[email protected]>
… some code cleanups. (#49714)
… some code cleanups. (ray-project#49714) Signed-off-by: Puyuan Yao <[email protected]>
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.