Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data] fix groupby hang when value contains np.nan #49420

Merged
merged 3 commits into from
Jan 2, 2025
Merged

[data] fix groupby hang when value contains np.nan #49420

merged 3 commits into from
Jan 2, 2025

Conversation

Jay-ju
Copy link
Contributor

@Jay-ju Jay-ju commented Dec 24, 2024 •
edited by richardliaw
Loading

Why are these changes needed?

closes #49276

Related issue number

#49276

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Jay-ju Jay-ju requested a review from a team as a code owner December 24, 2024 03:12
@Jay-ju Jay-ju force-pushed the fix_nan_group branch 2 times, most recently from 729b983 to 5677b37 Compare December 24, 2024 06:44
@jcotant1 jcotant1 added the data Ray Data-related issues label Dec 27, 2024
richardliaw
richardliaw approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the PR - works now across different batch formats (pandas too) and moved your test out into a more general test - in all_to_all

@richardliaw richardliaw added the go add ONLY when ready to merge, run all tests label Dec 29, 2024
@richardliaw richardliaw changed the title [data] fix array contain nan element in group by [data] fix groupby hang when array contains np.nan Dec 29, 2024
@richardliaw richardliaw changed the title [data] fix groupby hang when array contains np.nan [data] fix groupby hang when value contains np.nan Dec 29, 2024
@Jay-ju Jay-ju force-pushed the fix_nan_group branch 2 times, most recently from 0130e53 to db48b8e Compare December 30, 2024 03:19
@richardliaw
Copy link
Contributor

tests still failing?

@Jay-ju Jay-ju force-pushed the fix_nan_group branch 2 times, most recently from 4da1e2d to a3a2c69 Compare January 2, 2025 07:37
Jay-ju and others added 3 commits January 2, 2025 16:52
@Jay-ju
[data] fix array contain nan element in group by
8790abf 
Signed-off-by: jukejian <[email protected]>
@richardliaw @Jay-ju
[data] fix ut
4a67083 
Signed-off-by: jukejian <[email protected]>

update

[data] add dataloader for lance datasource
Signed-off-by: jukejian <[email protected]>
@Jay-ju
[data] fix array contain nan element in group by
65a91ab 
Signed-off-by: jukejian <[email protected]>
@Jay-ju
Copy link
Contributor Author

Jay-ju commented Jan 2, 2025

tests still failing?

It has been processed.

@richardliaw richardliaw merged commit 3ffca28 into ray-project:master Jan 2, 2025
5 checks passed
srinathk10 pushed a commit that referenced this pull request Jan 3, 2025
@Jay-ju @srinathk10
[data] fix groupby hang when value contains np.nan (#49420)
fbe71ff
roshankathawate pushed a commit to roshankathawate/ray that referenced this pull request Jan 7, 2025
@Jay-ju
[data] fix groupby hang when value contains np.nan (ray-project#49420)
a06628a
roshankathawate pushed a commit to roshankathawate/ray that referenced this pull request Jan 9, 2025
@Jay-ju @roshankathawate
[data] fix groupby hang when value contains np.nan (ray-project#49420)
ea8f81f 
Signed-off-by: Roshan Kathawate <[email protected]>
anyadontfly pushed a commit to anyadontfly/ray that referenced this pull request Feb 13, 2025
@Jay-ju @anyadontfly
[data] fix groupby hang when value contains np.nan (ray-project#49420)
d99e402 
Signed-off-by: Puyuan Yao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees
No one assigned
Labels
data Ray Data-related issues go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data] Groupby aggregation (min/max/count) hangs when the group column has NaN
3 participants
@Jay-ju @richardliaw @jcotant1