Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autoscaler][Placement Group] Skip placed bundle when requesting resource #48924

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −1
Open

[Autoscaler][Placement Group] Skip placed bundle when requesting resource #48924

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f6a78f
skip placed bundle when request resource
mimiliaogo Nov 25, 2024
5818b44
Merge branch 'master' into pg-overprovision
mimiliaogo Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion python/ray/autoscaler/_private/resource_demand_scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,8 +985,14 @@ def placement_groups_to_resource_demands(
"""
resource_demand_vector = []
unconverted = []
shapes = []
for placement_group in pending_placement_groups:
shapes = [dict(bundle.unit_resources) for bundle in placement_group.bundles]
# Skip **placed** bundle (which has node id associated with it).
for bundle in placement_group.bundles:
if bundle.node_id:
continue
shapes.append(dict(bundle.unit_resources))

if (
placement_group.strategy == PlacementStrategy.PACK
or placement_group.strategy == PlacementStrategy.SPREAD
Expand Down