Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Add APPO Atari (Pong) release test. #48681

Merged
merged 6 commits into from
Nov 11, 2024
Merged

[RLlib] Add APPO Atari (Pong) release test. #48681

merged 6 commits into from
Nov 11, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Nov 11, 2024 •
edited
Loading

Add APPO Atari (Pong) release test.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 added rllib RLlib related issues release-test release test rllib-newstack labels Nov 11, 2024
@sven1977
wip
7d38c2b 
Signed-off-by: sven1977 <[email protected]>
simonsays1980
simonsays1980 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977 sven1977 enabled auto-merge (squash) November 11, 2024 14:42
@sven1977 sven1977 disabled auto-merge November 11, 2024 14:42
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Nov 11, 2024
@sven1977
wip
62afab5 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 enabled auto-merge (squash) November 11, 2024 14:43
@github-actions github-actions bot disabled auto-merge November 11, 2024 14:45
@sven1977
merge
57aabbf 
Signed-off-by: sven1977 <[email protected]>
@sven1977
LINT
72e6cdd 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 enabled auto-merge (squash) November 11, 2024 18:57
@sven1977 sven1977 merged commit b0b1fb1 into ray-project:master Nov 11, 2024
6 checks passed
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@sven1977 @JP-sDEV
[RLlib] Add APPO Atari (Pong) release test. (ray-project#48681)
63a634d 
Signed-off-by: JP-sDEV <[email protected]>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@sven1977 @mohitjain2504
[RLlib] Add APPO Atari (Pong) release test. (ray-project#48681)
04233cb 
Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

Assignees

@simonsays1980 simonsays1980

Labels
go add ONLY when ready to merge, run all tests release-test release test rllib RLlib related issues rllib-newstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @simonsays1980