[serve] raise RequestCancelledError when request is cancelled during assignment #48496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
edoakes
reviewed
Nov 1, 2024
python/ray/serve/handle.py
Outdated
Comment on lines
353
to
354
| except asyncio.CancelledError: | ||
| raise RequestCancelledError from None |
There was a problem hiding this comment.
Doesn't this take the request ID as an arg?
There was a problem hiding this comment.
hmmm yeah, it's optional though. let me see if we can get ahold of the request metadata here.
There was a problem hiding this comment.
added request ID, ptal!
Tested manually, example:
Traceback (most recent call last):
File "/Users/cindyz/workspace/test.py", line 44, in <module>
second_response.result()
File "/Users/cindyz/ray/python/ray/serve/handle.py", line 498, in result
replica_result = self._fetch_future_result_sync(timeout_s)
File "/Users/cindyz/ray/python/ray/serve/handle.py", line 334, in _fetch_future_result_sync
raise RequestCancelledError(self.request_id) from None
ray.serve.exceptions.RequestCancelledError: Request 83479b13-3676-46d3-9193-6be135718f2a was cancelled.
There was a problem hiding this comment.
maybe let's make it required so this is consistent
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
…assignment (ray-project#48496) ## Why are these changes needed? Currently `ray.serve.exceptions.RequestCancelledError` is raised only when a request is cancelled during execution. We should also raise `RequestCancelledError` when a request is cancelled during assignment. --------- Signed-off-by: Cindy Zhang <[email protected]>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…assignment (ray-project#48496) ## Why are these changes needed? Currently `ray.serve.exceptions.RequestCancelledError` is raised only when a request is cancelled during execution. We should also raise `RequestCancelledError` when a request is cancelled during assignment. --------- Signed-off-by: Cindy Zhang <[email protected]>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…assignment (ray-project#48496) ## Why are these changes needed? Currently `ray.serve.exceptions.RequestCancelledError` is raised only when a request is cancelled during execution. We should also raise `RequestCancelledError` when a request is cancelled during assignment. --------- Signed-off-by: Cindy Zhang <[email protected]> Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently
ray.serve.exceptions.RequestCancelledErroris raised only when a request is cancelled during execution. We should also raiseRequestCancelledErrorwhen a request is cancelled during assignment.