Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Add constant for __env__ key. #47047

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

simonsays1980
Copy link
Collaborator

Why are these changes needed?

This PR adds a constant INPUT_ENV_SPACES to rllib/env/__init__.py to replace the __env__ key in code. It should identify the linked spaces as the spaces in the original user input.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…ld identify the spaces of the environment as they are in the input from the user to out 'AlgorithmConfig'.

Signed-off-by: simonsays1980 <[email protected]>
@simonsays1980 simonsays1980 marked this pull request as ready for review August 9, 2024 09:39
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @simonsays1980

@sven1977 sven1977 enabled auto-merge (squash) August 9, 2024 17:47
@sven1977 sven1977 disabled auto-merge August 9, 2024 17:47
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 9, 2024
@sven1977 sven1977 changed the title [RLlib] - Add constant for __env__ key [RLlib] Add constant for __env__ key. Aug 9, 2024
@sven1977 sven1977 enabled auto-merge (squash) August 9, 2024 17:48
@github-actions github-actions bot disabled auto-merge August 9, 2024 18:16
@sven1977 sven1977 merged commit eceb38a into ray-project:master Aug 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants