Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc typos. #47037

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

zhanluxianshen
Copy link
Contributor

@zhanluxianshen zhanluxianshen commented Aug 8, 2024

Why are these changes needed?

Fix doc typos.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@zhanluxianshen zhanluxianshen changed the title Fix doc quickstart. Fix doc typos. Aug 10, 2024
@zhanluxianshen zhanluxianshen force-pushed the fix-doc-quickstart branch 3 times, most recently from 4ba5029 to 0e4dbd4 Compare August 12, 2024 11:41
@anyscalesam anyscalesam enabled auto-merge (squash) August 12, 2024 21:28
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 12, 2024
auto-merge was automatically disabled August 12, 2024 22:18

Head branch was pushed to by a user without write access

@zhanluxianshen
Copy link
Contributor Author

zhanluxianshen commented Aug 12, 2024

@anyscalesam
thanks for the merge.
The code is rebased frequency. would you help to auto merge again?

@can-anyscale can-anyscale enabled auto-merge (squash) August 12, 2024 22:34
@github-actions github-actions bot disabled auto-merge August 12, 2024 22:37
@can-anyscale
Copy link
Collaborator

still need a stamp from many other code owners it seems

@anyscalesam anyscalesam enabled auto-merge (squash) August 13, 2024 00:09
@github-actions github-actions bot disabled auto-merge August 13, 2024 00:09
@zhanluxianshen
Copy link
Contributor Author

... disabled auto-merge

Copy link
Contributor

@omatthew98 omatthew98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@zhanluxianshen
Copy link
Contributor Author

wouldn't you merge directly? The code is changed so frequent, once rebased, the auto-merge is canceld.

Signed-off-by: zhanluxianshen <[email protected]>
@anyscalesam anyscalesam merged commit 76a20ef into ray-project:master Aug 22, 2024
5 checks passed
@zhanluxianshen zhanluxianshen deleted the fix-doc-quickstart branch August 22, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants