Fixes the flaky mutable_object_test #44413
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a local issue I resolved, I believe this commit should fix the flaky mutable_object_test in #44396.
The header of the mutable object was not being explicitly initialized. In some cases, this caused deadlock due to a spinlock backed by garbage memory.
This commit explicitly initializes the header, which should resolve the issue.
Tested: mutable_object_test
Why are these changes needed?
See above.
Related issue number
Closes #44396.
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.