Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Change log level for ignored exceptions #44408

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Apr 2, 2024

Why are these changes needed?

Ray Data gives you the option to ignore some number of errored blocks (for example, if you have some faulty data in your dataset). Currently, we log these exceptions as warnings. This PR updates the code to log the exceptions as errors.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani merged commit e8b0f80 into ray-project:master Apr 2, 2024
5 checks passed
@bveeramani bveeramani deleted the change-log-type branch April 2, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants