Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][release] fix release tests, upgrade typepy #40149

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

can-anyscale
Copy link
Collaborator

Upgrade typepy, typepy 1.3.1 is broken

https://buildkite.com/ray-project/release-tests-branch/builds/2225#018afbb2-428e-4364-b26c-7c49052edd26

#14 80.99 ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not:
--
  | 2023-10-05 07:42:44 PDT | #14 80.99     typepy<2,>=1.2.0 from https://files.pythonhosted.org/packages/f1/10/0d6dc654bb4e0eca017bbaf43a315b464c888576a68a2883cd4a74bd1b6b/typepy-1.3.2-py3-none-any.whl (from tabledata==1.3.1->-r requirements_ml_byod_3.9.txt (line 2259))

Test:

  • CI
  • Install requirements_ml_byod_3.9.txt locally

Signed-off-by: can <[email protected]>
@can-anyscale can-anyscale requested a review from a team as a code owner October 5, 2023 15:41
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@aslonnie
Copy link
Collaborator

aslonnie commented Oct 5, 2023

how / why exactly was it broken?

@can-anyscale
Copy link
Collaborator Author

@aslonnie i'm not exactly sure but pip insists for the latest version of typepy in its resolver

can-anyscale added a commit that referenced this pull request Oct 5, 2023
Signed-off-by: can <[email protected]>
@can-anyscale can-anyscale mentioned this pull request Oct 5, 2023
@can-anyscale can-anyscale merged commit 24f0abc into master Oct 5, 2023
@can-anyscale can-anyscale deleted the can-fix-release-test branch October 5, 2023 17:20
GeneDer pushed a commit that referenced this pull request Oct 5, 2023
Zandew pushed a commit to Zandew/ray that referenced this pull request Oct 10, 2023
Upgrade typepy, typepy 1.3.1 is broken

https://buildkite.com/ray-project/release-tests-branch/builds/2225#018afbb2-428e-4364-b26c-7c49052edd26

ray-project#14 80.99 ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not:
--
  | 2023-10-05 07:42:44 PDT | ray-project#14 80.99     typepy<2,>=1.2.0 from https://files.pythonhosted.org/packages/f1/10/0d6dc654bb4e0eca017bbaf43a315b464c888576a68a2883cd4a74bd1b6b/typepy-1.3.2-py3-none-any.whl (from tabledata==1.3.1->-r requirements_ml_byod_3.9.txt (line 2259))

Test:
- CI
- Install requirements_ml_byod_3.9.txt locally

Signed-off-by: can <[email protected]>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Upgrade typepy, typepy 1.3.1 is broken

https://buildkite.com/ray-project/release-tests-branch/builds/2225#018afbb2-428e-4364-b26c-7c49052edd26

ray-project#14 80.99 ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not:
--
  | 2023-10-05 07:42:44 PDT | ray-project#14 80.99     typepy<2,>=1.2.0 from https://files.pythonhosted.org/packages/f1/10/0d6dc654bb4e0eca017bbaf43a315b464c888576a68a2883cd4a74bd1b6b/typepy-1.3.2-py3-none-any.whl (from tabledata==1.3.1->-r requirements_ml_byod_3.9.txt (line 2259))

Test:
- CI
- Install requirements_ml_byod_3.9.txt locally

Signed-off-by: can <[email protected]>
Signed-off-by: Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants