-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci][release] fix release tests, upgrade typepy #40149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: can <[email protected]>
GeneDer
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
aslonnie
approved these changes
Oct 5, 2023
how / why exactly was it broken? |
@aslonnie i'm not exactly sure but pip insists for the latest version of typepy in its resolver |
can-anyscale
added a commit
that referenced
this pull request
Oct 5, 2023
Signed-off-by: can <[email protected]>
Merged
GeneDer
pushed a commit
that referenced
this pull request
Oct 5, 2023
Zandew
pushed a commit
to Zandew/ray
that referenced
this pull request
Oct 10, 2023
Upgrade typepy, typepy 1.3.1 is broken https://buildkite.com/ray-project/release-tests-branch/builds/2225#018afbb2-428e-4364-b26c-7c49052edd26 ray-project#14 80.99 ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not: -- | 2023-10-05 07:42:44 PDT | ray-project#14 80.99 typepy<2,>=1.2.0 from https://files.pythonhosted.org/packages/f1/10/0d6dc654bb4e0eca017bbaf43a315b464c888576a68a2883cd4a74bd1b6b/typepy-1.3.2-py3-none-any.whl (from tabledata==1.3.1->-r requirements_ml_byod_3.9.txt (line 2259)) Test: - CI - Install requirements_ml_byod_3.9.txt locally Signed-off-by: can <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Upgrade typepy, typepy 1.3.1 is broken https://buildkite.com/ray-project/release-tests-branch/builds/2225#018afbb2-428e-4364-b26c-7c49052edd26 ray-project#14 80.99 ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not: -- | 2023-10-05 07:42:44 PDT | ray-project#14 80.99 typepy<2,>=1.2.0 from https://files.pythonhosted.org/packages/f1/10/0d6dc654bb4e0eca017bbaf43a315b464c888576a68a2883cd4a74bd1b6b/typepy-1.3.2-py3-none-any.whl (from tabledata==1.3.1->-r requirements_ml_byod_3.9.txt (line 2259)) Test: - CI - Install requirements_ml_byod_3.9.txt locally Signed-off-by: can <[email protected]> Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade typepy, typepy 1.3.1 is broken
https://buildkite.com/ray-project/release-tests-branch/builds/2225#018afbb2-428e-4364-b26c-7c49052edd26
Test: