Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setting s3 endpoint-url via env var #36114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harelwa
Copy link
Contributor

@harelwa harelwa commented Jun 6, 2023

Why are these changes needed?

Support providing custom S3 endpoint URL via environment variable.

This is needed for when ray is used with S3-like storage (MinIO, VAST, etc.)

I have added support for two standard env var names:

  • AWS_ENDPOINT_URL
  • S3_ENDPOINT_URL

I will update the docs accordingly once this is approved

Related issue number

Closes #30601

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@harelwa harelwa force-pushed the runtime-env-support-s3-endpoint-url branch from e641b5f to 50f525e Compare June 6, 2023 08:18
@harelwa harelwa changed the title add setting endpoint-url via env var add setting s3 endpoint-url via env var Jun 7, 2023
@harelwa
Copy link
Contributor Author

harelwa commented Jun 20, 2023

hi,

can you pls merge this?

thanks,

harel

@stale
Copy link

stale bot commented Aug 10, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Aug 10, 2023
@harelwa
Copy link
Contributor Author

harelwa commented Aug 10, 2023

hi,

can you pls merge this?

thanks,

harel

@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Aug 10, 2023
@stale
Copy link

stale bot commented Sep 16, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Sep 16, 2023
Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harelwa, thanks for the contribution and sorry for the delay in getting this reviewed. According to this boto/boto3#2099 (comment), am I understanding correctly that this functionality is now included in boto3 itself?

@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Sep 26, 2023
@architkulkarni architkulkarni added the @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. label Sep 28, 2023
Copy link

stale bot commented Dec 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Dec 15, 2023
@chris-aeviator
Copy link

would love to see this contribution merged since minio is a critical part of on-prem infrastructure for many today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. stale The issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Support arbitrarily s3 endpoint in working dir when downloading package in runtime_env
4 participants