-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add setting s3 endpoint-url via env var #36114
base: master
Are you sure you want to change the base?
add setting s3 endpoint-url via env var #36114
Conversation
Signed-off-by: harelwa <[email protected]>
e641b5f
to
50f525e
Compare
hi, can you pls merge this? thanks, harel |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
hi, can you pls merge this? thanks, harel |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @harelwa, thanks for the contribution and sorry for the delay in getting this reviewed. According to this boto/boto3#2099 (comment), am I understanding correctly that this functionality is now included in boto3
itself?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
would love to see this contribution merged since minio is a critical part of on-prem infrastructure for many today |
Why are these changes needed?
Support providing custom S3 endpoint URL via environment variable.
This is needed for when
ray
is used with S3-like storage (MinIO, VAST, etc.)I have added support for two standard env var names:
AWS_ENDPOINT_URL
S3_ENDPOINT_URL
I will update the docs accordingly once this is approved
Related issue number
Closes #30601
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.