[Serve] Fix serve.shutdown() to delete deployments from all applications #32631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are alive and tracked by the deployment state manager Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
shrekris-anyscale
approved these changes
Feb 21, 2023
|
@sihanwang41 ping for review |
sihanwang41
approved these changes
Feb 22, 2023
|
@edoakes Should be ready for merge |
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…ons (ray-project#32631) `serve.shutdown()` only deletes deployments from app with `name=""`. This fix makes sure it deletes all deployments. Signed-off-by: Edward Oakes <[email protected]>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
…ons (ray-project#32631) `serve.shutdown()` only deletes deployments from app with `name=""`. This fix makes sure it deletes all deployments.
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…ons (ray-project#32631) `serve.shutdown()` only deletes deployments from app with `name=""`. This fix makes sure it deletes all deployments. Signed-off-by: elliottower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
serve.shutdown()only deletes deployments from app withname="". This fix makes sure it deletes all deployments.Related issue number
Closes #32623
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.