-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kuberay][autoscaler] Use new autoscaling fields from the KubeRay operator #25386
[kuberay][autoscaler] Use new autoscaling fields from the KubeRay operator #25386
Conversation
Hmm...getting some logs claiming the operator doesn't have permissions to list service accounts, but the RBAC looks as expected...need to debug more. |
Ok, having the issue with the operator not being able to list service accounts in upstream KubeRay as well. |
Ok...no, definitely not my K8s cluster...going to keep debugging. |
...lol... |
There's some incorrect downscaling behavior which is causing the test to fail. Going to debug. |
Welcome, codeowner SWAT team. |
For once, autoscaler was correct, I (test) was wrong. Test fixed. Let's wait for CI to run. |
Head pod failed to start in the CI, very strange...will probably have to debug the CI environment. |
It's an issue with ImagePull policy for the autoscaler container. This will require another quick fix to the KubeRay repo. |
...crossing fingers that it works and I don't have to debug it in the CI environment again.... |
Ah. There's the green check mark. |
100% green, except for the forsaken MacOS tests, which never run. |
Updates the autoscaler image to reflect changes from ray-project/ray#25386
Updates the autoscaler image to reflect changes from ray-project/ray#25386
Why are these changes needed?
This PR incorporates changes from KubeRay PRs ray-project/kuberay#163 ray-project/kuberay#274 ray-project/kuberay#278
upscalingMode
andidleTimeoutSeconds
in the KubeRay CRautoscalerOptions.image
field to set the autoscaler image in the testidleTimeoutSeconds
to test scale-down in the autoscaler e2e testChecks
scripts/format.sh
to lint the changes in this PR.