Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listen to 127.0.0.1 if node ip is 127.0.0.1 #19810

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Listen to 127.0.0.1 if node ip is 127.0.0.1 #19810

merged 1 commit into from
Oct 28, 2021

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Oct 27, 2021

Why are these changes needed?

This should fixed the new mac popups in #18730

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao jjyao requested a review from ijrsvt October 27, 2021 23:15
@jjyao jjyao requested a review from ckw017 October 27, 2021 23:16
ckw017
ckw017 approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@ckw017 ckw017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, very good catch. Sorry for any trouble caused trying to hunt down this popup source.

@jjyao jjyao added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Oct 28, 2021
@jjyao
Copy link
Collaborator Author

jjyao commented Oct 28, 2021

Tests passed. Can someone merge it since I don't have the permission.

@ijrsvt
Copy link
Contributor

ijrsvt commented Oct 28, 2021

Windows failures are flaky on master.

@ijrsvt ijrsvt merged commit fe8138b into ray-project:master Oct 28, 2021
@jjyao jjyao deleted the jjyao/localhost branch October 28, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckw017 ckw017 ckw017 approved these changes

@ijrsvt ijrsvt Awaiting requested review from ijrsvt

Assignees

@ckw017 ckw017

@ijrsvt ijrsvt

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjyao @ijrsvt @ckw017