[Lint] Add flake8-bugbear #19053
Merged
[Lint] Add flake8-bugbear #19053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
approved these changes
Oct 3, 2021
Which file you are talking about? I have already added it to python/requirements_linters.txt. |
rkooo567
approved these changes
Oct 3, 2021
rkooo567
reviewed
Oct 3, 2021
| @@ -83,6 +83,10 @@ if [[ $(flake8 --version) != *"flake8_quotes"* ]]; then | |||
| echo "WARNING: Ray uses flake8 with flake8_quotes. Might error without it. Install with: pip install flake8-quotes" | |||
| fi | |||
|
|
|||
| if [[ $(flake8 --version) != *"flake8-bugbear"* ]]; then | |||
| echo "WARNING: Ray uses flake8 with flake8-bugbear. Might error without it. Install with: pip install flake8-bugbear" | |||
There was a problem hiding this comment.
Why don't we just fail it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
flakey-bugbear has some extra checks for python anti-patterns like mutable default argument.
We can iterate on what checks to include/exclude.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.