Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Print out the mismatched commit in ci #18956

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Sep 28, 2021

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567
Copy link
Contributor

Before merging this, can you run some tests locally with this PR? Maybe try cherry-picking it with 1.7 and test it?

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Sep 29, 2021
@krfricke krfricke merged commit 35774fd into ray-project:master Sep 29, 2021
@krfricke
Copy link
Contributor

I merged this since it only adds a print to the assertion, i.e. behavior is basically the same as before

@jjyao
Copy link
Collaborator Author

jjyao commented Sep 29, 2021

Yea, I tested it locally and the cmd it builds works correctly.

@jjyao jjyao deleted the jjyao/ci branch September 29, 2021 14:59
@rkooo567
Copy link
Contributor

Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants