Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen to 127.0.0.1 by default on mac osx #18904

Merged
merged 9 commits into from
Sep 29, 2021
Merged

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Sep 26, 2021

Why are these changes needed?

For mac osx, only accepts connections from 127.0.0.1 by default so we can avoid the security popups.

Related issue number

Closes #18730

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao
Copy link
Collaborator Author

jjyao commented Sep 27, 2021

Still need to fix some tests.

@ericl
Copy link
Contributor

ericl commented Sep 27, 2021

Some tests failing.

//python/ray/tests:test_ray_init FAILED in 3 out of 3 in 91.1s
  | Stats over 3 runs: max = 91.1s, min = 90.3s, avg = 90.6s, dev = 0.3s
  | /private/var/tmp/_bazel_ec2-user/77b73149fdea129819071ba882f1e62a/execroot/com_github_ray_project_ray/bazel-out/darwin-opt/testlogs/python/ray/tests/test_ray_init/test.log
  | /private/var/tmp/_bazel_ec2-user/77b73149fdea129819071ba882f1e62a/execroot/com_github_ray_project_ray/bazel-out/darwin-opt/testlogs/python/ray/tests/test_ray_init/test_attempts/attempt_1.log
  | /private/var/tmp/_bazel_ec2-user/77b73149fdea129819071ba882f1e62a/execroot/com_github_ray_project_ray/bazel-out/darwin-opt/testlogs/python/ray/tests/test_ray_init/test_attempts/attempt_2.log
 

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Sep 27, 2021
@jjyao jjyao added the do-not-merge Do not merge this PR! label Sep 28, 2021
@jjyao jjyao added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. do-not-merge Do not merge this PR! labels Sep 29, 2021
@jjyao jjyao requested a review from ericl September 29, 2021 14:55
@ericl ericl merged commit ed91183 into ray-project:master Sep 29, 2021
@worldveil
Copy link
Contributor

worldveil commented Sep 30, 2021

THANK YOU @jjyao !!!

edit: checked the diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Ray Mac OSX security popups every time I run script locally
4 participants