Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[usability] fix bugs in the warning message #18898

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented Sep 25, 2021

Fix two issues user reports:

  1. we missed an argument for color_for
TypeError: color_for() missing 1 required positional argument: 'line'
  1. seeming to miss info in the prefixing dict sometimes, causing data["..."] to crash.

Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm any idea where the missing pid is coming from?

@scv119
Copy link
Contributor Author

scv119 commented Sep 25, 2021 via email

@ericl ericl merged commit aaae8c1 into ray-project:master Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants