Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] [doc] Improve runtime env doc #18782

Merged
merged 12 commits into from
Sep 27, 2021

Conversation

architkulkarni
Copy link
Contributor

@architkulkarni architkulkarni commented Sep 21, 2021

Closes #18781.

  • Update code snippet to use dynamically installed pip packages instead of preinstalled conda environments
  • Test snippet in CI
  • Add best practice to doc: for packages that build from source, precompile rather than putting in runtime env

https://ray--18782.org.readthedocs.build/en/18782/serve/core-apis.html#dependency-management

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes edoakes merged commit d4d7198 into ray-project:master Sep 27, 2021
fishbone added a commit that referenced this pull request Sep 28, 2021
ericl pushed a commit that referenced this pull request Sep 28, 2021
architkulkarni added a commit that referenced this pull request Sep 28, 2021
edoakes pushed a commit that referenced this pull request Sep 30, 2021
* Revert "Revert "[Serve] [doc] Improve runtime env doc (#18782)" (#18935)"

This reverts commit e4f4c79.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[serve] Improve docs for runtime_env best practices
3 participants