[Serve] gate __del__ call behind hasattr check #18773
Conversation
| @@ -355,7 +355,8 @@ async def prepare_for_shutdown(self): | |||
| # We set the del method to noop after succssifully calling it so the | |||
| # destructor is called only once. | |||
| try: | |||
| self.callable.__del__() | |||
| if hasattr(self.callable, "__del__"): | |||
There was a problem hiding this comment.
Not sure if it's better to put this outside the whole try-except block, but it's probably not very consequential
There was a problem hiding this comment.
this should be totally fine!
| @@ -355,7 +355,8 @@ async def prepare_for_shutdown(self): | |||
| # We set the del method to noop after succssifully calling it so the | |||
| # destructor is called only once. | |||
| try: | |||
| self.callable.__del__() | |||
| if hasattr(self.callable, "__del__"): | |||
There was a problem hiding this comment.
this should be totally fine!
|
note to self: this wasn't caught during that commit because the errors are silently logged but not thrown. In the future, we can add logging output test to capture any unexpected output. |
|
I was having the same issue. @simon-mo why isn't this set to |
|
@davidberenstein1957 are you still seeing this issue in ray nightly? https://docs.ray.io/en/master/installation.html#daily-releases-nightlies |
Why are these changes needed?
Related issue number
Closes #18772
Checks
scripts/format.shto lint the changes in this PR.