[Tune] Break from loop after warning msg is logged. #18720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmeerHajAli
reviewed
Sep 17, 2021
| @@ -303,6 +304,7 @@ def _may_warn_insufficient_resources(self, all_trials): | |||
| # Raise an Error once #18608 is resolved. | |||
| logger.warning( | |||
There was a problem hiding this comment.
My own experience is we output a lot of PENDING logs (see the linked output in description) and that can easily distract user from the useful output.
There was a problem hiding this comment.
Yeah, that's a good point.
richardliaw
approved these changes
Sep 17, 2021
|
windows tests are not related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Break out of the loop when warning is logged, so not to spam the log.
Also change the freq of logging such warning to be 60s.
Tested by both unit test and manually running a Tune script locally.
Output:
https://gist.github.com/xwjiang2010/a02782eef66901b51b52a4c08b6732e7
It's printed once per 60s and only for one trial.
Related issue number
Closes #18718
Checks
scripts/format.shto lint the changes in this PR.