[tune] Remove deprecated features, promote warnings to errors #18595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 14, 2021 11:22
krfricke
requested review from
xwjiang2010,
richardliaw,
Yard1 and
matthewdeng
krfricke
commented
Sep 14, 2021
| else: | ||
| raise DeprecationWarning(error_msg) | ||
|
|
||
|
|
There was a problem hiding this comment.
This was not used at all
added 2 commits
September 14, 2021 11:34
Yard1
approved these changes
Sep 14, 2021
|
This is blocked by https://buildkite.com/ray-project/ray-builders-pr/builds/13749#ed001a69-91e5-40b0-bedf-4a64f25cde04 |
added 5 commits
September 15, 2021 11:25
# Conflicts: # python/requirements/tune/requirements_upstream.txt
xwjiang2010
reviewed
Sep 16, 2021
xwjiang2010
reviewed
Sep 16, 2021
xwjiang2010
reviewed
Sep 16, 2021
|
|
||
| if isinstance(self._space, list): | ||
| # Keep for backwards compatibility | ||
| # Deprecate: 1.5 |
There was a problem hiding this comment.
I think marking "deprecate: 1.X" is a good practice. We should adopt that rigorously as part of depreciation cycle.
xwjiang2010
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This Pr removes some older deprecated features. For other deprecated features, it promotes the warning to an actual error. It also removes some deprecated arguments from tune.run.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.