Remove abi flag #18538
Merged
Remove abi flag #18538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still looking into why this fails. |
raulchen
reviewed
Sep 15, 2021
ci/travis/ci.sh
Outdated
| @@ -206,8 +206,11 @@ test_cpp() { | |||
| bazel test //cpp:cluster_mode_test --test_arg=--external_cluster=true --test_arg=--redis_password="1234" \ | |||
| --test_arg=--ray_redis_password="1234" | |||
|
|
|||
| # run the cpp example | |||
| cd cpp/example && sh run.sh | |||
| # avoid abi issue. | |||
There was a problem hiding this comment.
Add a TODO, and explain why we need to skip this test in CI.
qicosmos
force-pushed
the
remove_abi_flag
branch
from
b059c96 to
3546501
Compare
raulchen
reviewed
Sep 16, 2021
| @@ -199,6 +199,7 @@ test_python() { | |||
| } | |||
|
|
|||
| test_cpp() { | |||
| echo build --cxxopt="-D_GLIBCXX_USE_CXX11_ABI=0" >> ~/.bazelrc | |||
raulchen
approved these changes
Sep 16, 2021
|
Thanks for this change! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Remove the ABI flag: _GLIBCXX_USE_CXX11_ABI.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.