Explain how to know whether RAY_BACKEND_LOG_LEVEL worked #12010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
approved these changes
Nov 13, 2020
|
Thanks again for all this contribution @dHannasch! They are really valuable!! :) |
|
I will make sure to review other PRs asap! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, it can be unclear if
RAY_BACKEND_LOG_LEVELisn't working for any reason (such as actually settingRAY_BACKED_LOG_LEVEL).Related issue number
This would have had merge conflicts with #11956, so this incorporates #11956. (#11956 has already been approved, so it seems safe to assume #11956 is going to be merged.)
Checks
scripts/format.shto lint the changes in this PR.