Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added address resolution fix for running in docker containers #11944

Merged
merged 3 commits into from
Nov 24, 2020
Merged

added address resolution fix for running in docker containers #11944

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b062bb7
added address resolution fix for running in docker containers
roireshef Nov 11, 2020
7706d3f
added address resolution fix for running in docker containers (java)
roireshef Nov 12, 2020
7d3bc87
Update RayNativeRuntime.java
ericl Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/ray/_private/services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,8 @@ def get_address_info_from_redis_helper(redis_address,
client_node_ip_address = client_info["NodeManagerAddress"]
if (client_node_ip_address == node_ip_address
or (client_node_ip_address == "127.0.0.1"
and redis_ip_address == get_node_ip_address())):
and redis_ip_address == get_node_ip_address())
Copy link
Contributor

@dHannasch dHannasch Nov 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come to think of it, do we actually want get_node_ip_address(redis_address) here rather than leaving the argument as the default 8.8.8.8? If the GlobalState will be reporting the IP addresses that it sees from the perspective of redis_address (which might not always be the same as the view from 8.8.8.8 Google DNS)?

or client_node_ip_address == redis_ip_address):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we call ray.init from worker node (not head node), this will return the wrong address info. We should return the given worker node address info not the head node address info. @roireshef @ericl

relevant_client = client_info
break
if relevant_client is None:
Expand Down