Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APIServer][Docs] Identify API server as community-managed and optional #753

Merged

Conversation

DmitriGekhtman
Copy link
Collaborator

Signed-off-by: Dmitri Gekhtman [email protected]

Why are these changes needed?

There's some user confusion concerning whether the KubeRay API Server and KubeRay CLI are required components.
This PR adds some clarifying notes and adds maintainer contacts (@Jeffwan @scarlet25151).
Let me know if this list of maintainers should be modified.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: Dmitri Gekhtman <[email protected]>
@DmitriGekhtman DmitriGekhtman added docs Improvements or additions to documentation apiserver labels Nov 22, 2022
@DmitriGekhtman DmitriGekhtman changed the title [APIServer] Identify API server as community-managed and optional [APIServer][Dpcs] Identify API server as community-managed and optional Nov 22, 2022
@DmitriGekhtman DmitriGekhtman changed the title [APIServer][Dpcs] Identify API server as community-managed and optional [APIServer][Docs] Identify API server as community-managed and optional Nov 22, 2022
@DmitriGekhtman
Copy link
Collaborator Author

We should also split the instructions for Operator and API server deployment, explaining how to

  • Deploy the operator (required)
  • Deploy the API server (optional)
  • Deploy both at once

Copy link
Collaborator

@scarlet25151 scarlet25151 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thanks for the contribution!

@DmitriGekhtman DmitriGekhtman merged commit a8ec758 into ray-project:master Nov 22, 2022
@DmitriGekhtman DmitriGekhtman deleted the dmitri/kuberay-api-server branch November 22, 2022 21:29
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
…al (ray-project#753)

There's some user confusion concerning whether the KubeRay API Server and KubeRay CLI are required components.
This PR adds some clarifying notes and adds maintainer contacts (@Jeffwan @scarlet25151).

Signed-off-by: Dmitri Gekhtman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apiserver docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants