[Feature] Add a chart-test script to enable chart lint error reproduction on laptop #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DmitriGekhtman, I should write some documents about this PR, but I am not sure which document is better. Maybe DEVELOPMENT.md? Thank you! |
|
Yeah, I think development.md is the way to go. |
|
This looks good -- but please do add to this PR a brief section to Development.MD mentioning this test script. |
Update the document. Thank you! |
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…tion on laptop (ray-project#563) It is used to reproduce the helm chart lint errors on GitHub Actions. If you cannot reproduce the errors on GitHub Actions, the possible reason is the difference versions of Helm. Issue ray-project#537 is an example that some errors only happen in old helm versions. Usage: Step1: Install ct (chart-testing) and related dependencies. See https://github.com/helm/chart-testing for more details. Step2: ./helm-chart/script/chart-test.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
It is used to reproduce the helm chart lint errors on GitHub Actions. If you cannot reproduce the errors on GitHub Actions, the possible reason is the difference versions of Helm. Issue #537 is an example that some errors only happen in old helm versions.
Usage:
./helm-chart/script/chart-test.shRelated issue number
Part of #559
Checks