Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick master fixes to release-0.3 #478

Merged
merged 4 commits into from
Aug 16, 2022

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Aug 16, 2022

Cherry-pick following changes to release-0.3 branch

image

Why are these changes needed?

for stable release

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Jeffwan and others added 4 commits August 15, 2022 23:19
* helm-charts/ray-cluster: Allow extra workers

We can not set additional workers with the current helm chart.
There are some PRs that aim to fix this but they appear to be stale
ray-project#266

We wanted to keep untouched the default worker that is already
included in the helm chart but allow the addition of new workers.

The changes are adding the following logic:
- Allow to disable the default worker group, if needed, via worker.disabled = true
- Allow to set additional workers by using the extraWorkers map

The extraWorkers map has a different structure compared to the default worker because we
wanted to add additional flexibility. Due to that, some variables in the extraWorkers
have different naming (which matches the name of the related CRD attributed)

Note: PR was done to support additional workers in the infrastructure of Metrika.co
@Jeffwan Jeffwan changed the base branch from master to release-0.3 August 16, 2022 06:23
@Jeffwan Jeffwan requested a review from scarlet25151 August 16, 2022 06:23
@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 16, 2022

/cc @ulfox @scarlet25151 I cherry-pick your changes to release branch before official 0.3.0 release. Please have a check

Copy link
Collaborator

@scarlet25151 scarlet25151 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

@Jeffwan Jeffwan merged commit 2759c6d into ray-project:release-0.3 Aug 16, 2022
@Jeffwan Jeffwan deleted the cherry-pick-0.3-release branch August 16, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants