Validate namespace consistency in the request when creating the cluster and the compute template #365
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daikeshi
force-pushed
the
validate-namespace-consistency
branch
from
4292c8a to
d776b4f
Compare
Jeffwan
reviewed
Jul 8, 2022
|
This change will address the issue described here #347 (comment) |
daikeshi
force-pushed
the
validate-namespace-consistency
branch
from
d776b4f to
32b4558
Compare
daikeshi
force-pushed
the
validate-namespace-consistency
branch
from
32b4558 to
982faab
Compare
daikeshi
changed the title
Jeffwan
approved these changes
Jul 8, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a validation for cluster request to make sure the namespace in the request is same as the one defined in the Ray cluster.
Why are these changes needed?
Related issue number
Checks