Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove extraPortMappings from kind configurations #1366

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Aug 27, 2023

Why are these changes needed?

Kind's extraPortMappings configuration is for NodePort or Ingress. However, we do not use these Kubernetes functionalities in CI tests. In addition, I cannot use kubectl port-forward to check Ray dashboard if the kind cluster is created by this Kind configurations.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421 kevin85421 changed the title [CI] Update kind configurations [CI] Remove extraPortMappings from kind configurations Aug 27, 2023
@kevin85421 kevin85421 marked this pull request as ready for review August 27, 2023 05:51
@kevin85421 kevin85421 merged commit 629bc8f into ray-project:master Aug 28, 2023
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
)

[CI] Remove extraPortMappings from kind configurations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants