[RayJob] Add runtime env YAML field #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
kevin85421
reviewed
Aug 16, 2023
Signed-off-by: Archit Kulkarni <[email protected]>
…rni/kuberay into add-runtime-env-yaml
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
…add-runtime-env-yaml
blublinsky
pushed a commit
to blublinsky/kuberay
that referenced
this pull request
Aug 25, 2023
Adds the field RuntimeEnvYAML to the RayJob CRD which accepts a multi-line YAML string. This format is preferred for two reasons: Consistency with the ServeConfigV2 format, which is also a Ray configuration specified as a multi-line YAML string (Related to above) Allows using snake_case fields without modification We preserve the older field RuntimeEnv which accepts a base64-encoded string of the runtime env. We mark it as deprecated in the documentation. We raise an error if both fields are specified. Related issue number Closes ray-project#1195 --------- Signed-off-by: Archit Kulkarni <[email protected]>
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Adds the field RuntimeEnvYAML to the RayJob CRD which accepts a multi-line YAML string. This format is preferred for two reasons: Consistency with the ServeConfigV2 format, which is also a Ray configuration specified as a multi-line YAML string (Related to above) Allows using snake_case fields without modification We preserve the older field RuntimeEnv which accepts a base64-encoded string of the runtime env. We mark it as deprecated in the documentation. We raise an error if both fields are specified. Related issue number Closes ray-project#1195 --------- Signed-off-by: Archit Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds the field
RuntimeEnvYAMLto theRayJobCRD which accepts a multi-line YAML string. This format is preferred for two reasons:ServeConfigV2format, which is also a Ray configuration specified as a multi-line YAML stringWe preserve the older field
RuntimeEnvwhich accepts a base64-encoded string of the runtime env. We mark it as deprecated in the documentation.We raise an error if both fields are specified.
Related issue number
Closes #1195
Checks