-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug][RayJob] RayJob with custom head service name #1332
Conversation
f0d4469
to
e15cf3b
Compare
This looks good 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Do you think we should add your manual test YAML to the RayJob sample YAML tests so that the e2e behavior is tested in CI? |
@kevin85421 I think it's independent and you don't need to wait, I think you would just need to add the yaml to the list of tested yamls in test_sample_rayjob_yamls.py |
@architkulkarni I have already added a test |
RayJob with custom head service name
RayJob with custom head service name
RayJob with custom head service name
Why are these changes needed?
As @mmourafiq pointed out in #1326 (comment), some users prefer a deterministic head service name for RayJob in order to set up a reverse proxy. Although we've made the entire head service configurable, there are some issues that arise when we set the name of the head service:
Related issue number
Closes #1294
Checks