Api server makefile #1301
Merged
Api server makefile #1301
+343
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jeffwan, @scarlet25151 and @kevin85421 I would very much appreciate your feedback on this PR. |
kevin85421
reviewed
Aug 9, 2023
kevin85421
reviewed
Aug 9, 2023
kevin85421
reviewed
Aug 10, 2023
kevin85421
approved these changes
Aug 12, 2023
tedhtchang
reviewed
Aug 14, 2023
| | kubectl | v1.18.3+ | [Download](https://kubernetes.io/docs/tasks/tools/install-kubectl/) | | ||
| | Go | v1.13+ | [Download](https://golang.org/dl/) | | ||
| | Docker | 19.03+ | [Download](https://docs.docker.com/install/) | | ||
| | Go | v1.17 | [Download](https://golang.org/dl/) | |
There was a problem hiding this comment.
@blublinsky The go version does not match the minimal support go version in the go.mod file.
There was a problem hiding this comment.
@blublinsky No need to do anything. @kevin85421 created the issue to update the go version.
blublinsky
pushed a commit
to blublinsky/kuberay
that referenced
this pull request
Aug 15, 2023
Api server makefile
blublinsky
pushed a commit
to blublinsky/kuberay
that referenced
this pull request
Aug 15, 2023
Api server makefile
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Api server makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The value of these changes is to facilitate the local development of new features for the KubeRay API Server component. It is a precursor to further work I and @blublinsky intend to do on integrating KubeRay API Server into the Codeflare stack.
Related issue number
None.
Checks