-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Develop Ray Serve Python script on KubeRay #1250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just some minor comments.
Near the beginning, it would be good to have some sort of summary like
"In this tutorial, you will learn how to easily debug your RayService by manually running a Ray Serve script against a RayCluster. This is a useful strategy for debugging a RayService because (... you can either locally using kind
or on a remote cluster, or other reasons...)"
I'm guessing that compared to RayService, the iteration speed is faster with this approach? Or it's easier to see the underlying error message?
docs/guidance/rayserve-dev-doc.md
Outdated
|
||
Many RayService issues are related to the Ray Serve Python scripts. | ||
We strongly recommend that users develop and test their Ray Serve scripts in a RayCluster using the same Ray image before deploying them to a RayService. | ||
In this tutorial, we will show you how to develop [ray-service.mobilenet.yaml](https://github.com/ray-project/kuberay/blob/master/ray-operator/config/samples/ray-service.mobilenet.yaml). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to add a 1 sentence description of what mobilenet
is and why we're using it in the tutorial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated: 638d7bc
Co-authored-by: Archit Kulkarni <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Updated: f656a58 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and the intro is very clear now!
Develop Ray Serve Python script on KubeRay
Develop Ray Serve Python script on KubeRay
Develop Ray Serve Python script on KubeRay
Why are these changes needed?
Related issue number
Closes #1176
Checks