-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Update version from 0.4.0 to 0.5.0 on remaining kuberay docs files #1018
[Doc] Update version from 0.4.0 to 0.5.0 on remaining kuberay docs files #1018
Conversation
Signed-off-by: Archit Kulkarni <[email protected]>
Maybe you can use 0.4.0, v0.4.0, and 0.4 in your VSCode search to make sure all versions are replaced? |
Yup that's what I did, the rest of them did not make sense to change (e.g. it was referring specifically to 0.4.0 not 0.5.0, or it was using 0.4.0 as an example in some release process doc) |
There seem to be some documents that need to be updated. For example,
Do I miss anything? |
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Ah I wasn't sure if I was supposed to update those. I've updated them now, that should be everything |
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Updated the rest of the files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The updates for APIServer and proto
leave to @scarlet25151 and @Jeffwan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks good to me. /lgtm Thanks!
@@ -2,7 +2,7 @@ | |||
"swagger": "2.0", | |||
"info": { | |||
"title": "KubeRay API", | |||
"version": "0.4.0", | |||
"version": "0.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's generated correctly.
…les (ray-project#1018) Some files (ray service doc, kuberay operator doc, kind doc) still were using 0.4.0 in their examples. This PR updates them to 0.5.0.
Some files (ray service doc, kuberay operator doc, kind doc) still were using 0.4.0 in their examples. This PR updates them to 0.5.0.
Why are these changes needed?
Related issue number
Checks