Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kuberay 0.5.0 docs validation update docs for GCS FT #1004

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

scarlet25151
Copy link
Collaborator

Why are these changes needed?

Update docs for best practice docs.

for kuberay 0.5.0 we mark the GCS FT feature to stable.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@scarlet25151 scarlet25151 changed the title update docs Kuberay 0.5.0 docs validation update docs for GCS FT Apr 3, 2023
Copy link
Collaborator

@wilsonwang371 wilsonwang371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update!

docs/best-practice/worker-head-reconnection.md Outdated Show resolved Hide resolved
docs/guidance/gcs-ft.md Outdated Show resolved Hide resolved
Signed-off-by: chenyu.jiang <[email protected]>
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others look good to me.

docs/best-practice/worker-head-reconnection.md Outdated Show resolved Hide resolved
docs/guidance/gcs-ft.md Outdated Show resolved Hide resolved
scarlet25151 and others added 2 commits April 5, 2023 13:47
Co-authored-by: Kai-Hsun Chen <[email protected]>
Signed-off-by: Chenyu Jiang <[email protected]>
Co-authored-by: Kai-Hsun Chen <[email protected]>
Signed-off-by: Chenyu Jiang <[email protected]>
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the update!

@kevin85421
Copy link
Member

This PR only updates documents and has no relationship with CI tests. Merge this PR before CI passes.

@kevin85421 kevin85421 merged commit ca9348d into ray-project:master Apr 5, 2023
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Kuberay 0.5.0 docs validation update docs for GCS FT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants