Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation section to explain running the workflow only on a specified branch #119

Conversation

joshmfrankel
Copy link
Contributor

@joshmfrankel joshmfrankel commented Nov 9, 2023

image

I added a simple section to the readme in order to explain running the notifier on a specific branch.

Copy link
Contributor

ravsam-bot bot commented Nov 9, 2023

Hello and welcome to RavSam 💜. Thanks for opening your first pull request. We really appreciate your work for our organization. I will assign one of our team members to review your pull request. The reviewer will review your work and merge the pull request accordingly.

Thanks.

@ravsam-bot ravsam-bot bot requested a review from ravgeetdhillon November 9, 2023 15:57
@@ -43,7 +60,6 @@ steps:
notification_title: "{workflow} has {status_message}"
message_format: "{emoji} *{workflow}* {status_message} in <{repo_url}|{repo}>"
footer: "Linked Repo <{repo_url}|{repo}> | <{workflow_url}|View Workflow>"
notify_when: "failure"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the screenshot shows a success message while notify_when is set to only failures. This just makes the config match the screenshot :-)

Copy link
Member

@ravgeetdhillon ravgeetdhillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ravsam-bot ravsam-bot bot merged commit 1bd6e6b into ravsamhq:master Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants