Cristhian ocola solve node js challenge #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
| }); | ||
|
|
||
| const callsResponse = { |
There was a problem hiding this comment.
We can return directly here instead of creating a constant just to return it later
return {
totalCalls: processedCall.length,
total: parseFloat(totalCost.toFixed(2)),
callsDetails: processedCall
}
| @@ -39,6 +39,35 @@ | |||
| * @returns {CallsResponse} - Processed information | |||
| */ | |||
|
|
|||
| function callsCost(calls) { } | |||
| function callsCost(calls) { | |||
|
|
|||
There was a problem hiding this comment.
Apply formatting to files
| @@ -26,6 +26,75 @@ | |||
| * @returns {PeopleResponse} - Processed information | |||
| */ | |||
|
|
|||
| function peopleInformation(people) { } | |||
|
|
|||
| // function calculateAgeProm(people) { | |||
There was a problem hiding this comment.
Remove unused code
| return acc; | ||
| }, init); | ||
|
|
||
| const PeopleResponse = { |
There was a problem hiding this comment.
return {
"ageProm" : Math.round(metrics.totalAge / people.length),
"heightProm" : Math.round(metrics.totalHeight / people.length),
"youngerPerson" : metrics.youngerPerson,
"tallerPerson" : metrics.tallerPerson,
}
|
|
||
| let messageArray = message.split(''); | ||
|
|
||
| let answer = model.split('').map((char) => { |
There was a problem hiding this comment.
return model.split('').map((char) => {
if(char === character && messageArray.length > 0){
return messageArray.shift();
}else{
return char;
}
}).join('');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.