Challenges completed #5

Andre6-dev · 2024-11-20T22:06:53Z

I only have the comment that to read the json file you must put it in the src/main/resources/weather.json folder and also that the final solution for the additional challenge is the one that says WeatherAnalyzerOption2.java.

sbobadilla8 · 2024-11-21T02:00:22Z

src/main/java/ChallengeStream.java

+    private double calculateInternationalCost(int duration) {
+        // If the duration is more than the base minutes, calculate the cost for the additional minutes
+
+        double total = 0.00;
+        if (duration <= BASE_MINUTES) {
+            total += INTERNATIONAL_FIRST_3_MIN * duration;
+        } else {
+            total += (INTERNATIONAL_ADDITIONAL_MIN * (duration - BASE_MINUTES)) + (BASE_MINUTES * INTERNATIONAL_FIRST_3_MIN);
+        }
+        return total;
+    }
+
+    private double calculateNationalCost(int duration) {
+        // If the duration is more than the base minutes, calculate the cost for the additional minutes
+        double total = 0.00;
+        if (duration <= BASE_MINUTES) {
+            total += NATIONAL_FIRST_3_MIN * duration;
+        } else {
+            total += (NATIONAL_ADDITIONAL_MIN * (duration - BASE_MINUTES)) + (BASE_MINUTES * NATIONAL_FIRST_3_MIN);
+        }
+        return total;
+    }
+
+    private double calculateLocalCost(int duration) {
+        // In local it doesn't charge for the first minutes
+        return duration * LOCAL_PER_MIN;
+    }
+


This functions have very similar logic in them, perhaps you could simplify this?

sbobadilla8 · 2024-11-21T02:03:59Z

src/main/java/ChallengeStream.java

+        int player1Max = player1.stream()
+                // create a stream of all possible two-digit numbers
+                .flatMap(d1 -> player1.stream()
+                        .filter(d2 -> !d2.equals(d1)) // ensure that the two digits are different


Digits don't need to be different, a player could win with 11,22,...,99
Same for L122

What Sebastian said, please send a fix

sbobadilla8 · 2024-11-21T02:05:49Z

src/main/java/Challenges.java

+            sum = sum.add(power);
+        }
+
+        return sum.toString()


nit: if you're going to separate chained calls in multiple lines do so from the beginning so it is easy to follow.

sbobadilla8 · 2024-11-21T02:10:07Z

src/main/java/extraChallenge/Weather.java

+class LocationJson {
+    private double lon;
+    private double lat;
+
+    public LocationJson() {
+    }
+
+    public LocationJson(double lon, double lat) {
+        this.lon = lon;
+        this.lat = lat;
+    }
+
+    public double getLon() {
+        return lon;
+    }
+
+    public void setLon(double lon) {
+        this.lon = lon;
+    }
+
+    public double getLat() {
+        return lat;
+    }
+
+    public void setLat(double lat) {
+        this.lat = lat;
+    }
+}


This should be on its own separate file

sbobadilla8 · 2024-11-21T02:16:42Z

src/main/java/extraChallenge/WeatherAnalyzerOption2.java

+    private static boolean isValidRecord(Weather record) {
+        return record != null
+                && record.getAirtemp() >= 0
+                && record.getAtmosphericpressure() >= 0
+                && record.getGustspeed() >= 0
+                && record.getPrecipitation() >= 0
+                && record.getRelativehumidity() >= 0
+                && record.getSolar() >= 0
+                && record.getStrikedistance() >= 0
+                && record.getStrikes() >= 0
+                && record.getVapourpressure() >= 0
+                && record.getWindspeed() >= 0;
+    }


Be careful with this because there might be cases where the temperature is less than 0.

sbobadilla8 · 2024-11-21T02:17:34Z

src/main/java/extraChallenge/WeatherAnalyzerOption2.java

+            long startTime = System.currentTimeMillis();
+            analyzeWeatherData();
+            long endTime = System.currentTimeMillis();
+            System.out.println("\nExecution time: " + (endTime - startTime) + "ms");


Pretty cool you thought of adding this. Could you post the resulting processing time? I'm curious

This is the resulting processing time:

If I had thought of adding this I could've made a contest out of it. Too late now, but pretty cool that it is quick. Well done!

sbobadilla8

Great job overall. Just something you should take note of, whenever we are making a PR we only put the code we actually want in a production environment. So you shouldn't have a V1 or V2 (git takes care of that!). You mentioned option2 is the final version you would like to submit, so just submit that one.

sbobadilla8 · 2024-11-22T01:51:52Z

src/main/java/ChallengeStream.java

+    private Double calculateCallCost(CallCostObject call) {
+        return switch (call.getType()) {
+            case INTERNATIONAL -> calculateCostByType(call.getDuration(), INTERNATIONAL);
+            case NATIONAL -> calculateCostByType(call.getDuration(), NATIONAL);
+            case LOCAL -> calculateCostByType(call.getDuration(), LOCAL);
+            default -> 0.0;
+        };
+    }
+
+    private double calculateCostByType(int duration, String type) {
+        double total = 0.00;
+        double first3MinRate;
+        double additionalMinRate;
+
+        switch (type) {
+            case INTERNATIONAL -> {
+                first3MinRate = INTERNATIONAL_FIRST_3_MIN;
+                additionalMinRate = INTERNATIONAL_ADDITIONAL_MIN;
+            }
+            case NATIONAL -> {
+                first3MinRate = NATIONAL_FIRST_3_MIN;
+                additionalMinRate = NATIONAL_ADDITIONAL_MIN;
+            }
+            case LOCAL -> {
+                return duration * LOCAL_PER_MIN;
+            }
+            default -> throw new IllegalArgumentException("Invalid call type");
+        }
+
+        if (duration <= BASE_MINUTES) {
+            total = first3MinRate * duration;
+        } else {
+            total = (additionalMinRate * (duration - BASE_MINUTES)) + (BASE_MINUTES * first3MinRate);
+        }


This looks like it could be merged into a single function... since you're doing the same type of switch in both functions. Do you think you could simplify this?

sbobadilla8 · 2024-11-22T01:54:55Z

src/main/java/extraChallenge/Location.java

+    public Location() {
+    }


nit: for empty constructors you can put the curly braces in the same line to make it clearer it's empty on purpose.

sbobadilla8 · 2024-11-22T01:55:17Z

src/main/java/extraChallenge/Weather.java

+    public Weather() {
+    }


nit: same comment about {}

sbobadilla8 · 2024-11-22T02:04:46Z

src/main/java/extraChallenge/WeatherAnalyzer.java

+                && record.getAtmosphericpressure() >= 0
+                && record.getGustspeed() >= 0
+                && record.getPrecipitation() >= 0
+                && record.getRelativehumidity() >= 0
+                && record.getSolar() >= 0
+                && record.getStrikedistance() >= 0
+                && record.getStrikes() >= 0
+                && record.getVapourpressure() >= 0
+                && record.getWindspeed() >= 0;


I'm still wondering if this would be the correct way of checking if you have a correct record. You could so some sort of pre-processing or do a bit of research about the possible values you could get, but perhaps you could try just checking for null values.

sbobadilla8

Good improvement over previous version, left a couple more comments to keep you busy.

sbobadilla8 · 2024-11-22T19:18:35Z

src/main/java/extraChallenge/WeatherAnalyzer.java

+        double sum = 0;
+        double min = Double.MAX_VALUE;
+        double max = Double.MIN_VALUE;
+        long count = 0;


Super nit: I think that an int is enough here, I doubt the file has more than 2,147,483,647 records

sbobadilla8

Looks good!

quebin31 · 2024-11-27T16:22:01Z

src/main/java/ChallengeStream.java

+            case LOCAL -> {
+                return duration * LOCAL_PER_MIN;
+            }
+            default -> {
+                return 0.0;
+            }


nit: Code smell here, part of the switch doesn't return and part of it returns, this divergent behavior and could be confusing when reading the code

Andre6-dev added 13 commits November 13, 2024 10:08

Solving the first and second challenge.

90a3361

Implementing ownPower and digitSum

9fe8f8f

Fixing the method of ownPower

7d5f33a

Encrypt and Decrypt challenges done

c1f587f

Solving the challenges from ChallengeStream

bbf6785

Fixing the methods for calculateCost

338d7e2

Fixing the tests for the winning hand challenge

15b9454

Fixing the winningHand challenge with the latests tests

8a8f402

Adding the extra challenge

6a08914

Adding the solution using ConcurrentHashMap and process individually

4ebfca2

WeatherAnalyzerOption2 is my solution for extra challenge

be1d084

Remove weather.json from tracking and add to .gitignore

dcda702

Adding weather.json to gitignore

306b242

cmonterrosad requested review from quebin31, sergiolg98, sbobadilla8 and cmonterrosad November 20, 2024 22:11

sbobadilla8 reviewed Nov 21, 2024

View reviewed changes

Andre6-dev added 3 commits November 21, 2024 09:29

Simplifying the method for calculating the cost per type

da4d0ea

Fixing the observations of extraChallenge

afcc67e

Deleting comments

f9c75a0

Andre6-dev requested a review from sbobadilla8 November 21, 2024 21:00

sbobadilla8 reviewed Nov 22, 2024

View reviewed changes

Fixing the lasts observations made in my PR

86916e7

sbobadilla8 reviewed Nov 22, 2024

View reviewed changes

Andre6-dev requested a review from sbobadilla8 November 22, 2024 19:30

quebin31 reviewed Nov 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Challenges completed #5

Challenges completed #5

Andre6-dev commented Nov 20, 2024

sbobadilla8 Nov 21, 2024

sbobadilla8 Nov 21, 2024

quebin31 Nov 27, 2024

sbobadilla8 Nov 21, 2024

sbobadilla8 Nov 21, 2024

sbobadilla8 Nov 21, 2024

sbobadilla8 Nov 21, 2024

Andre6-dev Nov 22, 2024

sbobadilla8 Nov 22, 2024

sbobadilla8 left a comment

sbobadilla8 Nov 22, 2024

sbobadilla8 Nov 22, 2024

sbobadilla8 Nov 22, 2024

sbobadilla8 Nov 22, 2024

sbobadilla8 left a comment

sbobadilla8 Nov 22, 2024

sbobadilla8 left a comment

quebin31 Nov 27, 2024

Challenges completed #5

Are you sure you want to change the base?

Challenges completed #5

Conversation

Andre6-dev commented Nov 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbobadilla8 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbobadilla8 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbobadilla8 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment