develop into master: Challenges | Extra Challenge completed #3
Conversation
src/main/java/ChallengeStream.java
Outdated
| return new CardWinner(); | ||
| var player1Hand = player1.stream() | ||
| .sorted(Comparator.comparing((Integer i) -> i).reversed()) | ||
| .distinct() |
There was a problem hiding this comment.
I'm worried about this distinct, what if our hand was all the same digits? We would end up with a stream that has only one digit, which is incorrect, because all the other cards are still valid, e.x
[1,2,3,4,5] vs [5,5,5,5,5]
The winning hand for the left player is 54, while the winning hand for the right should be 55, with distinct I'm thinking you would get only 5
There was a problem hiding this comment.
refactored on 32577dd , then tested scenario described in description and passed
src/main/java/ChallengeStream.java
Outdated
| double totalCost = switch (callCostObject.getType()) { | ||
| case "International" -> | ||
| Double.parseDouble(String.format("%.2f", (duration * 7.56) + (extraMinutes * 3.03))); | ||
| case "National" -> | ||
| Double.parseDouble(String.format("%.2f", (duration * 1.20) + (extraMinutes * 0.48))); | ||
| case "Local" -> Double.parseDouble(String.format("%.2f", (duration * 0.2))); | ||
| default -> 0D; |
src/main/java/ChallengeStream.java
Outdated
| .collect(Collectors.groupingBy(CallCostObject::getType)); | ||
|
|
||
|
|
There was a problem hiding this comment.
nit: This group by operation seems a bit redundant, you could achieve the same with a map since you're just doing a flatMap later on in L79
There was a problem hiding this comment.
removed and simplified on 32577dd
src/main/java/Challenges.java
Outdated
| System.arraycopy(COUNTRY_NAMES, index, tempArray, 0, numberOfElementsToCopy); | ||
| System.arraycopy(COUNTRY_NAMES, 0, tempArray, numberOfElementsToCopy, COUNTRY_NAMES.length - numberOfElementsToCopy); | ||
|
|
||
| COUNTRY_NAMES = tempArray.clone(); |
There was a problem hiding this comment.
nit: If COUNTRY_NAMES were to be a static variable you would be breaking this function each time you called it, returning tempArray.clone directly would be less error prone
There was a problem hiding this comment.
refactored to directly return it on e235614
src/main/java/Challenges.java
Outdated
| String result = String.valueOf(powResult); | ||
|
|
||
| return result.substring(result.length() - lastDigits); |
src/main/java/Challenges.java
Outdated
| for (Integer num : ascivalues) { | ||
| number += num; | ||
| result.append((char) number); | ||
| } |
src/main/java/ChallengeStream.java
Outdated
|
|
||
| import mocks.CallCostObject; | ||
| import mocks.CallSummary; | ||
| import mocks.CardWinner; | ||
| import mocks.TotalSummary; | ||
|
|
||
| import java.util.Comparator; | ||
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
|
|
There was a problem hiding this comment.
nit: usually imports are ordered by putting first libraries (either external or from the STL) and then local imports from other directories.
src/main/java/ChallengeStream.java
Outdated
| return new CallSummary( | ||
| callCostObject, | ||
| totalCost | ||
| ); |
There was a problem hiding this comment.
nit: this return could be a single line of code, not worth splitting it.
|
Files that belong to Extra Challenge Solution: modified: pom.xml |
ferodrigop
changed the title
| // statistics of all records | ||
| statisticsOfRecords(listWeatherDataDTO); | ||
|
|
||
| // statistics of records per day | ||
| statisticsOfRecordsPerDay(listWeatherDataDTO); |
There was a problem hiding this comment.
Can you think of a way of gathering in results in a single call? So that the JSON is processed only once.
| public class StatisticsUtil { | ||
| public static Map<String, DoubleSummaryStatistics> calculateDoubleSummaryStatisticsOfObjectAttributes(List<?> records) { |
There was a problem hiding this comment.
Why are you using reflection for this?
Completed challenges then executed the commands:
mvn test -Dtests=ChallengesTest.java
mvn test -Dtests=ChallengesTest.java