✨ Async Nerdery Challenges Solutions #32
Conversation
…roup items into success and failure categories
…er method to promise based
1-callbacks/solution.js
Outdated
| @@ -32,16 +32,75 @@ node solution.js name1 name2 name3 | |||
| ** give a look to node.js util.promisify, avoid to alter the validate-user.file ** | |||
| */ | |||
|
|
|||
| function solution() { | |||
| // YOUR SOLUTION GOES HERE | |||
| const { Console } = require('node:console'); | |||
1-callbacks/solution.js
Outdated
|
|
||
| // iterate the names array and validate them with the method | ||
| const promises = names.map(name => { |
There was a problem hiding this comment.
You are not supposed to use promises in here. You should be using only callbacks to resolve this first exercise. Please update it accordingly
|
|
||
| function solution(names = []) { |
There was a problem hiding this comment.
This function is not being used, and it should
1-callbacks/solution.js
Outdated
| // you get your 5 names here | ||
| if (names.length === 0) names = NAMES; |
There was a problem hiding this comment.
Even if there is only one inner statement, always wrap your for loop and conditional statements in brackets, so it's more readable
1-callbacks/solution.js
Outdated
| // you get your 5 names here | ||
| if (names.length === 0) names = NAMES; |
There was a problem hiding this comment.
You could also take advantage of the Javascript's truthiness. This could also be
if (!names.length)
However, that's just a comment in case you didn't know. I, personally, prefer to be really explicit most of the time, just like you did
2-promises/solution.js
Outdated
| firstname = name | ||
| }) | ||
| .catch((error) => console.error(error)) | ||
| .finally(() => console.log(`fullname: ${firstname} ${lastname}`)) |
There was a problem hiding this comment.
.finally() is usually used for clean up or actions that should happen either if the promise resolves or rejects. This statement should be in the then part of the code, as right now it prints fullname: undefined undefined when we get an error
2-promises/solution.js
Outdated
| function getRandomId() { | ||
| const random = Math.random(); | ||
| if (random < 0.5) return '❌'; | ||
| const id = Math.floor(Math.random() * 100) |
There was a problem hiding this comment.
This will only generate values from 0-99, not up to 100 as requested
3-async-await/solution.js
Outdated
| const prices = require('./prices'); | ||
|
|
||
| function getId() { | ||
| return Number(String(Date.now()).slice(-2)); |
There was a problem hiding this comment.
This does work, but is really uncommon to use constructors for primitive types. You should have done something like
parseInt(Date.now().toString().slice(-2))There was a problem hiding this comment.
Could also use an arrow function for simplicity
const calculateRandomId = () => parseInt(Date.now().toString().slice(-2))| // You use Promise.all() here | ||
| // You use Promise.allSettled() here | ||
| // Log the results, or errors, here | ||
| const [product, price] = await Promise.all([products(id), prices(id)]); |
There was a problem hiding this comment.
You could have wrapped this and the Promise.all related code in a try catch, so the rest of the code works even if this one fails
| } | ||
| } catch (error) { | ||
| console.log(error) | ||
| } |
There was a problem hiding this comment.
Could you add a comment elaborating on your conclusion about Promise.race vs Promise.any
No description provided.