Francisco Hernandez - Challengues #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabio248
reviewed
Nov 20, 2024
1-callbacks/solution.js
Outdated
| @@ -31,17 +31,50 @@ node solution.js name1 name2 name3 | |||
| 5. another challenge is: after you solve the challenge using callback style, in another file promisify the callback and solve it again | |||
| ** give a look to node.js util.promisify, avoid to alter the validate-user.file ** | |||
| */ | |||
| import validateUser from "./validate-user.js"; | |||
There was a problem hiding this comment.
We are using CommonJS module, so we should to use require.
Suggested change
| import validateUser from "./validate-user.js"; | |
| const validateUser = require("./validate-user"); |
1-callbacks/solution.js
Outdated
Comment on lines
62
to
67
| counter++; | ||
| } | ||
|
|
||
| if (user) { | ||
| succesUsers.push(user); | ||
| counter++; |
There was a problem hiding this comment.
We can move the counter++ outside of the if statements, and have only one.
2-promises/solution.js
Outdated
Comment on lines
27
to
28
| import lastnames from "./lastnames.js"; | ||
| import firstnames from "./firstnames.js"; |
2-promises/solution.js
Outdated
Comment on lines
31
to
32
| const isValid = Math.random() > 0.5; | ||
| if (isValid) { |
There was a problem hiding this comment.
To improve readability we should add a blank space before the if statement
3-async-await/solution.js
Outdated
Comment on lines
2
to
16
| INSTRUCTIONS | ||
|
|
||
| 1. using async/await API consume products and prices methods | ||
| 2. don't use .then(), .catch() or .finally() here | ||
| 3. both, products and prices methods expect a positive integer id | ||
| 4. use Promise.all() and Promise.allSettled() to consume both methods in parallel | ||
| 5. to generate the id do the following: invoke Date.now(), and take the last two digits, this will be your id | ||
| 6. log the results with console.log(), the format is up to you, but it must include id, product and price | ||
|
|
||
| Example: | ||
| { | ||
| id:100, | ||
| product:'paper', | ||
| price:1 | ||
| } |
There was a problem hiding this comment.
We don't want to delete the instrucctions, so put them back and move your solution under them like other exercises.
3-async-await/solution.js
Outdated
Comment on lines
1
to
2
| import products from "./products.js"; | ||
| import prices from "./prices.js"; |
Comment on lines
+48
to
+56
| function solution() { | ||
| const numberOfIds = 5; | ||
| const IDs = Array.from({ length: numberOfIds }, generateRandomId); | ||
|
|
||
| Promise.all(IDs.map((id) => fetchNames(id))).then((names) => { | ||
| names.forEach((name) => { | ||
| console.log(`${name}\n`); | ||
| }); | ||
| }); |
3-async-await/solution.js
Outdated
Comment on lines
27
to
48
| const allFulfilled = resultsAllSettled.every( | ||
| (result) => result.status === "fulfilled" | ||
| ); | ||
|
|
||
| function solution() { | ||
| // YOUR SOLUTION GOES HERE | ||
| if (allFulfilled) { | ||
| const productName = resultsAllSettled[0].value; | ||
| const productPrice = resultsAllSettled[1].value; | ||
|
|
||
| // You generate your id value here | ||
| console.log(`(Promise.AllSettled):`, { | ||
| id: ID, | ||
| product: productName, | ||
| price: productPrice, | ||
| }); | ||
| } | ||
|
|
||
| // You use Promise.all() here | ||
| if (!allFulfilled) { | ||
| console.log( | ||
| `Error (Promise.allSettled): ${ | ||
| resultsAllSettled[0].reason || "Unknown error" | ||
| }` | ||
| ); | ||
| } |
There was a problem hiding this comment.
We can take the first error approach, where we first have the error validation and then our code without errors. That improves the readability of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for the nerdery challengues