Solution/kevinsalazar #13

deeiqh · 2022-07-29T23:14:00Z

No description provided.

FrankFuentes21 · 2022-08-09T03:32:12Z

3-async-await/solution.js

+    const products = require('./products');
+    const prices = require('./prices');


Imports should be at the beginning of the file

FrankFuentes21 · 2022-08-09T03:37:22Z

3-async-await/solution.js


-    // You use Promise.all() here
+    (async () => {


convert solution function into async function instead of doing this

ok, the challenge allowed to modify solution function.

FrankFuentes21 · 2022-08-09T03:44:53Z

3-async-await/solution.js


-    // You use Promise.allSettled() here
+        try {
+            [result.product, result.price] = await Promise.all([products(id), prices(id)]);


initialize other constants to get the results here

const [a, b] = await Promise.all()

ok, that way it's more readable

FrankFuentes21 · 2022-08-09T03:45:34Z

3-async-await/solution.js

-    // You use Promise.allSettled() here
+        try {
+            [result.product, result.price] = await Promise.all([products(id), prices(id)]);
+            console.log(


console.log({id, a, b})

ok, in this case printing as an object is better than formatting

FrankFuentes21 · 2022-08-09T03:46:14Z

3-async-await/solution.js


    // You generate your id value here
+    const id = Number((Date.now()+'').slice(-2));
+    const result = {id};


we can avoid doing it in this way. (See comments below)

FrankFuentes21 · 2022-08-09T03:49:37Z

3-async-await/solution.js

+        console.log(
+            `  id: ${id}\
+            \n  product: ${print(settled[0])}\
+            \n  price: ${print(settled[1])}\n`
+        );


print object

FrankFuentes21 · 2022-08-09T03:50:06Z

3-async-await/solution.js

+
+        console.log('\nPromise.allSettled:\n')
+
+        const settled = await Promise.allSettled([products(id), prices(id)]);


consider using more representative names

FrankFuentes21 · 2022-08-09T03:52:39Z

3-async-await/solution.js

+
+        console.log('\nPromise.race:\n');
+        try {
+            const value = await Promise.race([products(id), prices(id)]);


consider using more representative names

FrankFuentes21 · 2022-08-09T03:52:45Z

3-async-await/solution.js

+
+        console.log('\nPromise.any:\n');
+        try {
+            const value = await Promise.any([products(id), prices(id)]);


consider using more representative names

FrankFuentes21 · 2022-08-09T03:53:05Z

3-async-await/solution.js

+        } catch (reason) {
+            console.log(`   error: ${reason.message}`);
+        }
+    })();
 }

 solution()


should be async call

What is Promise any and race for?

Promise any and race are there just to compare visually their output with the Promise.all and Promise.allSettled ones, I did that just to take advantage of all outputs together.

FrankFuentes21 · 2022-08-09T03:56:40Z

2-promises/solution.js

+    const lastName = require('./lastnames');
+    const firstName = require('./firstnames');


Imports should be at the beginning of the file

FrankFuentes21 · 2022-08-09T04:03:35Z

2-promises/solution.js


-    // You log the fullname, or error, here
+    const fullName = {};


We can define variables for firstname and lastname instead

FrankFuentes21 · 2022-08-09T04:14:05Z

2-promises/solution.js

+        // You call the firstname method
+        .then(firstName => fullName.firstName = firstName)
+        // You log the fullname, or error, here
+        .then(_ => console.log(`${fullName.firstName} ${fullName.lastName}`))


Here we can use the 2 constants created above

ok, it is better and more readable that way

FrankFuentes21 · 2022-08-09T04:23:04Z

1-callbacks/solution.js

@@ -34,14 +34,46 @@ node solution.js name1 name2 name3

 function solution() {
    // YOUR SOLUTION GOES HERE
+    const validateUser = require('./validate-user');


imports should be at the beginning of the file

FrankFuentes21 · 2022-08-09T04:24:26Z

1-callbacks/solution.js

+            error ? 
+                console.log(error.message)
+                : console.log(`\nid:${user.id}\nname: ${user.name}`);


validate existence of error using if condition

Which considerations should we take using map?

you're right, my mistake in using map instead of other loop like forEach because map, in this case, is reducing performance.

FrankFuentes21 · 2022-08-09T04:25:42Z

3-async-await/solution.js

+        } catch (reason) {
+            console.log(`   error: ${reason.message}`);
+        }
+    })();
 }

 solution()


What is Promise any and race for?

FrankFuentes21 · 2022-08-09T04:26:52Z

1-callbacks/promisify-Callback.js

+        new Promise (resolve => {
+            validateUser(name, (error, user) => {
+                error ?
+                    resolve(failure.push(error.message))
+                    : resolve(success.push(user));
+            })
+        })


Use promisify method

FrankFuentes21 · 2022-08-09T04:27:16Z

1-callbacks/promisify-Callback.js

+
+function solution() {
+    // YOUR SOLUTION GOES HERE
+    let validateUser = require('./validate-user');


const instead of let and it should be at the beginning of the file

deeiqh added 4 commits July 29, 2022 15:18

feat: add solutions for callback challenge

e42a95f

feat: solve promises challenge

a8c4fb4

feat: solve async-await challenge

d193487

feat: add promise race and any to async-await challenge

1e2320d

deeiqh requested review from AlexisG13, DevMata and FrankFuentes21 and removed request for FrankFuentes21 July 29, 2022 23:14

FrankFuentes21 reviewed Aug 9, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Solution/kevinsalazar #13

Solution/kevinsalazar #13

deeiqh commented Jul 29, 2022

FrankFuentes21 Aug 9, 2022

FrankFuentes21 Aug 9, 2022

deeiqh Aug 10, 2022

FrankFuentes21 Aug 9, 2022

deeiqh Aug 10, 2022

FrankFuentes21 Aug 9, 2022

deeiqh Aug 10, 2022

FrankFuentes21 Aug 9, 2022

FrankFuentes21 Aug 9, 2022

FrankFuentes21 Aug 9, 2022

FrankFuentes21 Aug 9, 2022

deeiqh Aug 10, 2022

FrankFuentes21 Aug 9, 2022

FrankFuentes21 Aug 9, 2022

FrankFuentes21 Aug 9, 2022

deeiqh Aug 9, 2022

FrankFuentes21 Aug 9, 2022

FrankFuentes21 Aug 9, 2022

FrankFuentes21 Aug 9, 2022

deeiqh Aug 10, 2022 •

edited

Loading

FrankFuentes21 Aug 9, 2022

FrankFuentes21 Aug 9, 2022

FrankFuentes21 Aug 9, 2022

deeiqh Aug 9, 2022 •

edited

Loading

FrankFuentes21 Aug 9, 2022

FrankFuentes21 Aug 9, 2022

FrankFuentes21 Aug 9, 2022

		const products = require('./products');
		const prices = require('./prices');


		console.log('\nPromise.allSettled:\n')

		const settled = await Promise.allSettled([products(id), prices(id)]);

		const lastName = require('./lastnames');
		const firstName = require('./firstnames');

Solution/kevinsalazar #13

Are you sure you want to change the base?

Solution/kevinsalazar #13

Conversation

deeiqh commented Jul 29, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deeiqh Aug 10, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deeiqh Aug 9, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deeiqh Aug 10, 2022 •

edited

Loading

deeiqh Aug 9, 2022 •

edited

Loading