JS-Nerdery-Challenges/Rafael-David #78

RafoDev · 2024-11-15T18:32:41Z

Solution of the challenge algorithms.

marceloev123 · 2024-11-15T18:42:07Z

JS-Algorithms/challenges.js

+
+  const units = [hours, minutes, remainingSeconds];
+
+  const formattedUnits = units.map((unit) => unit.toString().padStart(2, '0'));


Nice way yo apply the needed unit transformation, I would prefer a better variable name like timeUnits instead of units but good work 👍

marceloev123 · 2024-11-15T18:43:40Z

JS-Algorithms/challenges.js

+
+  const formattedUnits = units.map((unit) => unit.toString().padStart(2, '0'));
+
+  return formattedUnits.join(':');


you can also return this directly right? but I understand why you separate this to have more readability 💯

return timeUnits.map((unit) => unit.toString().padStart(2, '0')).join(':');

marceloev123 · 2024-11-15T18:48:06Z

JS-Algorithms/challenges.js

@@ -41,7 +49,16 @@ Invoking "circularArray(2)" should return "["Island", "Japan", "Israel", "German
 const COUNTRY_NAMES = ["Germany", "Norway", "Island", "Japan", "Israel"];

 const circularArray = (index) => {
-  // YOUR CODE HERE...
+


What could happen if I send a negative number as an index here?

Which value will be appended if index is negative?

It will append an undefined at the beginning, I forgot to make that check.

marceloev123 · 2024-11-15T18:56:54Z

JS-Algorithms/challenges.js

+    .reduce((acc, currNum) => (acc + currNum) % modBase, 0)
+    .toString();
+
+  const boundedSumOfPowers = sumOfPowers.slice(sumOfPowers.length - lastDigits);


You can use a negative value in the slice function and it would have the same result

Suggested change

const boundedSumOfPowers = sumOfPowers.slice(sumOfPowers.length - lastDigits);

const boundedSumOfPowers = sumOfPowers.slice(-lastDigits);

marceloev123 · 2024-11-15T19:04:03Z

JS-Algorithms/challenges.js

@@ -70,7 +87,28 @@ The last 3 digits for the sum of powers from 1 to 10 is "317"
 ***** */

 const ownPower = (number, lastDigits) => {
-  // YOUR CODE HERE...
+  const modBase = Math.pow(10, lastDigits + 1);


I like this approach to not overflow numbers and be precise in the calculations, you can also use a BigInt instead of it but good usage

marceloev123 · 2024-11-15T19:07:31Z

JS-Algorithms/challenges.js

+
+  const boundedSumOfPowers = sumOfPowers.slice(sumOfPowers.length - lastDigits);
+
+  return boundedSumOfPowers;


Good solution, I like the different approach maybe for future references bear in mind that some of the functions can be chained

const modBase = Math.pow(10, lastDigits + 1); const sumOfPowers = Array.from({ length: number }, (_, idx) => { let poweredNumber = 1; for (let i = 0; i < idx + 1; i++) { poweredNumber = (poweredNumber * (idx + 1)) % modBase; } return poweredNumber; }) .reduce((acc, currentNumber) => (acc + currentNumber) % modBase, 0) .toString(); return sumOfPowers.slice(-lastDigits);

At first, I thought about sending it like that, but I wasn't sure how readable it would be. I'll keep it in mind for next time.

marceloev123 · 2024-11-15T19:10:57Z

JS-Algorithms/challenges.js

+
+  const serie = Array.from({ length: number }, (_, idx) => idx + 1);
+
+  const poweredSerie = serie.map((num) => {    


I know why you declare this variable as num but maybe you can be more descriptive in your variables, don't be shy of using large naming, maybe serieNumber ?

marceloev123 · 2024-11-15T19:11:40Z

JS-Algorithms/challenges.js

+  });
+
+  const sumOfPowers = poweredSerie
+    .reduce((acc, currNum) => (acc + currNum) % modBase, 0)


same about naming conventions

Suggested change

.reduce((acc, currNum) => (acc + currNum) % modBase, 0)

.reduce((acc, currentNumber) => (acc + currentNumber) % modBase, 0)

marceloev123 · 2024-11-15T19:12:20Z

JS-Algorithms/challenges.js

+    factorialOfN *= i;
+  }
+
+  const digitsInfactorialOfN = [...factorialOfN.toString()].map(


Why spread operator is needed?

Because factorialOfN.toString() returns a string, using the spread operator splits the string into individual characters and place them in an array, allowing me to apply a map.

marceloev123 · 2024-11-15T19:17:51Z

JS-Algorithms/challenges.js

+
+  const sumOfDigits = digitsInfactorialOfN.reduce((acc, num) => acc + num, 0);
+
+  return sumOfDigits;


Clever solution you can apply the number cast directly to the reduce function instead of separate it in two steps though

const sumOfDigits = [...factorialOfN.toString()].reduce((acc, digit) => acc + Number(digit), 0);

marceloev123 · 2024-11-15T19:18:42Z

JS-Algorithms/challenges.js

+  let index = 2;
+
+  // f(n) = f(n-1) + f(n-2)  
+  let n1 = 0;


Clear variables definition good work, however same thing about naming you can use other variable names

n1 = previousNumber
n2 = currentNumber

I would encourage you to use more descriptive names for variables

marceloev123 · 2024-11-15T19:21:52Z

JS-Algorithms/challenges.js

+  // f(n) = f(n-1) + f(n-2)  
+  let n1 = 0;
+  let n2 = 1;
+  let fn = 1;


I think fn can be removed, you can use n2 variable and have the same result right?

That's true, I hadn't noticed it.

marceloev123

Good work on finishing your JS challenge 🎉 , I noticed that sometimes you tend to separate things in extra steps, I think that you did it intentionally for code readability, however bear in mind that extra steps sometimes are unnecessary, I would like you to improve variables naming for future exercise too, good solutions so far, I think you have a good understanding when to use declarative functions

- Suggested more descriptive variable names for better clarity. - Removed redundant lines by chaining functions.

feat(challenges): complete exercises 1 to 5

b5b12d2

marceloev123 reviewed Nov 15, 2024

View reviewed changes

refactor(challenges): improve readability and efficiency

14e993e

- Suggested more descriptive variable names for better clarity. - Removed redundant lines by chaining functions.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JS-Nerdery-Challenges/Rafael-David #78

JS-Nerdery-Challenges/Rafael-David #78

RafoDev commented Nov 15, 2024

marceloev123 Nov 15, 2024 •

edited

Loading

marceloev123 Nov 15, 2024

marceloev123 Nov 15, 2024

marceloev123 Nov 15, 2024

RafoDev Nov 15, 2024

marceloev123 Nov 15, 2024 •

edited

Loading

marceloev123 Nov 15, 2024

marceloev123 Nov 15, 2024

RafoDev Nov 15, 2024

marceloev123 Nov 15, 2024 •

edited

Loading

marceloev123 Nov 15, 2024 •

edited

Loading

marceloev123 Nov 15, 2024

RafoDev Nov 15, 2024

marceloev123 Nov 15, 2024

marceloev123 Nov 15, 2024 •

edited

Loading

marceloev123 Nov 15, 2024

RafoDev Nov 15, 2024

marceloev123 left a comment •

edited

Loading


		const units = [hours, minutes, remainingSeconds];

		const formattedUnits = units.map((unit) => unit.toString().padStart(2, '0'));


		const formattedUnits = units.map((unit) => unit.toString().padStart(2, '0'));

		return formattedUnits.join(':');

	const boundedSumOfPowers = sumOfPowers.slice(sumOfPowers.length - lastDigits);
	const boundedSumOfPowers = sumOfPowers.slice(-lastDigits);


		const boundedSumOfPowers = sumOfPowers.slice(sumOfPowers.length - lastDigits);

		return boundedSumOfPowers;


		const serie = Array.from({ length: number }, (_, idx) => idx + 1);

		const poweredSerie = serie.map((num) => {

	.reduce((acc, currNum) => (acc + currNum) % modBase, 0)
	.reduce((acc, currentNumber) => (acc + currentNumber) % modBase, 0)


		const sumOfDigits = digitsInfactorialOfN.reduce((acc, num) => acc + num, 0);

		return sumOfDigits;

JS-Nerdery-Challenges/Rafael-David #78

Are you sure you want to change the base?

JS-Nerdery-Challenges/Rafael-David #78

Conversation

RafoDev commented Nov 15, 2024

marceloev123 Nov 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marceloev123 Nov 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marceloev123 Nov 15, 2024 • edited Loading

Choose a reason for hiding this comment

marceloev123 Nov 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marceloev123 Nov 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marceloev123 left a comment • edited Loading

Choose a reason for hiding this comment

marceloev123 Nov 15, 2024 •

edited

Loading

marceloev123 Nov 15, 2024 •

edited

Loading

marceloev123 Nov 15, 2024 •

edited

Loading

marceloev123 Nov 15, 2024 •

edited

Loading

marceloev123 Nov 15, 2024 •

edited

Loading

marceloev123 left a comment •

edited

Loading