Renato-JS-Nerdery-Challenge #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caceres97
reviewed
Apr 22, 2023
JS-Algorithms/challenges.js
Outdated
| const fact = (n) => { | ||
| let result = 1; | ||
| for (let i = n; i > 1; i--) { | ||
| result = result * i; |
caceres97
reviewed
Apr 22, 2023
JS-Algorithms/challenges.js
Outdated
| // YOUR CODE HERE... | ||
| if (!(n > 1)) return; | ||
|
|
||
| const fact = (n) => { |
There was a problem hiding this comment.
Better naming for variables and functions:
- The
factcan becalculateFactorial - You already had a variable named
nit can becalculatedNumber - You had a single parameter in your arrow function, so do that
const fact = n => {}
Remember that it's better to be very explicit with the names.
caceres97
reviewed
Apr 22, 2023
| @@ -95,7 +113,24 @@ Since 10! === 3628800 and you sum 3 + 6 + 2 + 8 + 8 + 0 + 0 | |||
| ***** */ | |||
|
|
|||
| const digitSum = (n) => { | |||
There was a problem hiding this comment.
Just a comment, you could avoid the function in this exercise.
const digitSum = (n) => {
if (!(n > 1)) return;
let result = 1;
let total = 0;
for (let i = n; i > 1; i--) {
result *= i;
}
const digits = String(BigInt(result));
for (const digit of digits) {
total += Number(digit);
}
return total;
};
caceres97
reviewed
Apr 22, 2023
JS-Algorithms/challenges.js
Outdated
| for (let i = 1; i <= number; i++) { | ||
| result += i ** i; | ||
| } | ||
| result = BigInt(result); |
There was a problem hiding this comment.
Do it in a single line: result = BigInt(result).toString();
caceres97
reviewed
Apr 22, 2023
| @@ -118,7 +153,11 @@ Because the 12th index in the Fibonacci sequence is 144, and 144 has three digit | |||
| ***** */ | |||
|
|
|||
| const fibIndex = (n) => { | |||
|
I leave you some comments, in general you did a good work! Congrats! |
|
I improved the code based on recommendations, thanks for your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my submit for the assignment