Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exercises): completed all exercises #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Menendez2004
Copy link

All required exercises have been completed and also tested

All required exercises have been completed and also tested
@Menendez2004 Menendez2004 changed the title feat(exercises): complete all exercises feat(exercises): completed all exercises Nov 27, 2024
Copy link

@fabio248 fabio248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice you formatted your queries that helps when you are reading but be more careful with typos and also do no modify unnecessary files.

Comment on lines +7 to +9
states s
JOIN
countries c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you assign the table's name after FROM or JOIN statement I prefer to use the 3 letters to improve readability in the query. I won't comment the same on the following queries but you should solve it there as well.


-- 2
SELECT COUNT(*) AS employees_wothout_bosses
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the typo in wothout

SELECT
c.name AS country_name,
o.address AS address,
COUNT(e.id) AS numer_employees
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the typo in numer


-- 4
SELECT
s.id AS supervisor_id,
COUNT(e.id) AS number_of_employe
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the typo in employe and it should be in plural.

@@ -1,5 +1,1681 @@
--er-- PostgreSQL database dumpia--
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't modify this file, just the answers.sql

Comment on lines +62 to +63
HAVING
s.name = 'Colorado';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants